From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqqBb-0007SP-AC for qemu-devel@nongnu.org; Mon, 16 Jul 2012 14:38:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqqBa-0003dJ-0z for qemu-devel@nongnu.org; Mon, 16 Jul 2012 14:38:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqqBZ-0003d0-Ik for qemu-devel@nongnu.org; Mon, 16 Jul 2012 14:38:21 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6GIc0RR016659 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 16 Jul 2012 14:38:21 -0400 Message-ID: <50044365.7080208@redhat.com> Date: Mon, 16 Jul 2012 10:37:57 -0600 From: Eric Blake MIME-Version: 1.0 References: <049abd55f3f85bac5d299ca34f17b9abd39fedc4.1342092497.git.phrdina@redhat.com> <4FFF106F.5070603@redhat.com> <5003CCEF.6070200@redhat.com> In-Reply-To: <5003CCEF.6070200@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigF301C21625217B0E17878FBD" Subject: Re: [Qemu-devel] [RFC PATCH 3/4] qapi: Convert delvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF301C21625217B0E17878FBD Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 07/16/2012 02:12 AM, Pavel Hrdina wrote: > On 07/12/2012 07:59 PM, Eric Blake wrote: >> On 07/12/2012 10:55 AM, Pavel Hrdina wrote: >>> Signed-off-by: Pavel Hrdina >>> --- >>> hmp-commands.hx | 2 +- >>> hmp.c | 10 ++++++++++ >>> hmp.h | 1 + >>> qapi-schema.json | 17 +++++++++++++++++ >>> qmp-commands.hx | 24 ++++++++++++++++++++++++ >>> savevm.c | 21 +++++++++++---------- >>> sysemu.h | 1 - >>> 7 files changed, 64 insertions(+), 12 deletions(-) >>> + >>> +## >>> +# @delvm: >> This name is worse than 'loadvm' or 'savevm', in that we are NOT >> deleting the entire vm, but a named snapshot stored within the vm. >> Would naming it 'delete-vm-snapshot' make more sense (in which case th= e >> others might make more sense as 'save-vm-snapshot' and >> 'load-vm-snapshot')? >> > This naming looks nice. I definitely agree that it could be > save-vm-snapshot, load-vm-snapshot, delete-vm-snapshot and > query-vm-snapshots. On seeing that spelled out, I wonder if the '-vm' is just noise; where we could use 'query-snapshots' instead of 'query-vm-snapshots'. Then again, we already have 'blockdev-snapshot-sync', which is an entirely different snapshot (just a block device, rather than the entire VM), so dropping -vm is probably a bad idea. Anyone else want to chime in on the bikeshed painting discussion of the best QMP name? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigF301C21625217B0E17878FBD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQBENmAAoJEKeha0olJ0Nqr+0IAJs3Wu2S9c9/p4QwhN39qZFm JjZfaaCzSYDEopAmlI67LIUHUkEbrRFuO5vqhU52TtslyYzQ2vuq5e/GBXfpGqLw IxmyjtRjpz4a1FAc9+jTVYtAdflloIZwWH6GCpXok2iXsXoFf0sYhHwvokAFYiam wDKqlP/Bf6nPiwEUUR7RjCHl8TJGEyHD0sjCk/jwl7ohh7PIMtSgxA1sbttaxDXl ctAY/WrY6dmciZMSX1jRXhm/jFe3WjuJU9suwvNoQ+PZEanhBBKrxdMQCCWEWmwP 0n3j3JuVwa1lYIzvyk27dUHt65g7TJPy1sQ6Xp7Zyt9xH6oF+RTRzKYxRgM6cvk= =Lg7V -----END PGP SIGNATURE----- --------------enigF301C21625217B0E17878FBD--