From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqvIt-0006qD-7B for qemu-devel@nongnu.org; Mon, 16 Jul 2012 20:06:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqvIs-0005vl-1g for qemu-devel@nongnu.org; Mon, 16 Jul 2012 20:06:15 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:42417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqvIr-0005vd-T3 for qemu-devel@nongnu.org; Mon, 16 Jul 2012 20:06:13 -0400 Received: by obbta14 with SMTP id ta14so10424998obb.4 for ; Mon, 16 Jul 2012 17:06:12 -0700 (PDT) Message-ID: <5004AC71.9020703@acm.org> Date: Mon, 16 Jul 2012 19:06:09 -0500 From: Corey Minyard MIME-Version: 1.0 References: <1342383911-6094-1-git-send-email-minyard@acm.org> <50043747.6050801@redhat.com> In-Reply-To: <50043747.6050801@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/16] smbios: Add a function to directly add an entry Reply-To: minyard@acm.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Corey Minyard , qemu-devel@nongnu.org On 07/16/2012 10:46 AM, Eric Blake wrote: > On 07/15/2012 02:24 PM, minyard@acm.org wrote: >> From: Corey Minyard >> >> There was no way to directly add a table entry to the SMBIOS table, >> even though the BIOS supports this. So add a function to do this. >> This is in preparation for the IPMI handler adding it's SMBIOS table >> entry. >> >> Signed-off-by: Corey Minyard >> --- >> hw/smbios.c | 27 +++++++++++++++++++++++++++ >> hw/smbios.h | 15 ++++++++------- >> 2 files changed, 35 insertions(+), 7 deletions(-) > Are you planning to expose this via the command line? Libvirt would > like the ability to set arbitrary name/value pairs in SMBIOS (such as > asset tag in the type 3 page), rather than the current limitation of > only being able to set pre-defined names in just type 0 and 1 sections. > Well, I wan't planning on it, I only did what I needed for IPMI. Adding a command line interface would be more learning that I can probably afford right now. -corey