From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46378)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1SqvJm-0007Xf-GC
	for qemu-devel@nongnu.org; Mon, 16 Jul 2012 20:07:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1SqvJl-00060X-Ig
	for qemu-devel@nongnu.org; Mon, 16 Jul 2012 20:07:10 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:65381)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1SqvJl-00060T-DS
	for qemu-devel@nongnu.org; Mon, 16 Jul 2012 20:07:09 -0400
Received: by obbta14 with SMTP id ta14so10426078obb.4
	for <qemu-devel@nongnu.org>; Mon, 16 Jul 2012 17:07:09 -0700 (PDT)
Message-ID: <5004ACAA.4040800@acm.org>
Date: Mon, 16 Jul 2012 19:07:06 -0500
From: Corey Minyard <tcminyard@gmail.com>
MIME-Version: 1.0
References: <1342383911-6094-1-git-send-email-minyard@acm.org>
	<1342383911-6094-10-git-send-email-minyard@acm.org>
	<5003B3B9.90908@redhat.com>
In-Reply-To: <5003B3B9.90908@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 10/16] qom: release previous object when
	setting
Reply-To: minyard@acm.org
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Corey Minyard <cminyard@mvista.com>, qemu-devel@nongnu.org

On 07/16/2012 01:24 AM, Paolo Bonzini wrote:
> Il 15/07/2012 22:25, minyard@acm.org ha scritto:
>> From: Corey Minyard <cminyard@mvista.com>
>>
>> When setting an object, if you don't release the previous object
>> that was there, it may become unusable.  This change allows a
>> chardev to be removed from one object's properties and added to
>> another's.
>> ---
>>   qom/object.c |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/qom/object.c b/qom/object.c
>> index 00bb3b0..484dc77 100644
>> --- a/qom/object.c
>> +++ b/qom/object.c
>> @@ -731,6 +731,8 @@ void object_property_set(Object *obj, Visitor *v, const char *name,
>>       if (!prop->set) {
>>           error_set(errp, QERR_PERMISSION_DENIED);
>>       } else {
>> +	if (prop->release)
>> +	    prop->release(obj, name, prop->opaque);
>>           prop->set(obj, v, prop->opaque, name, errp);
>>       }
>>   }
>>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>
> ... but you need to run scripts/checkpatch.pl on your patches to conform
> to coding style.
Ok.  I'm running everything through the script.  I didn't realize the 
coding standard was that different from Linux.

Thanks,

-corey