From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sr5R4-0003g0-6K for qemu-devel@nongnu.org; Tue, 17 Jul 2012 06:55:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sr5Qz-0003lu-Go for qemu-devel@nongnu.org; Tue, 17 Jul 2012 06:55:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sr5Qz-0003lp-7O for qemu-devel@nongnu.org; Tue, 17 Jul 2012 06:55:17 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6HAtG9X028365 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 17 Jul 2012 06:55:16 -0400 Message-ID: <50054491.9070103@redhat.com> Date: Tue, 17 Jul 2012 12:55:13 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <049abd55f3f85bac5d299ca34f17b9abd39fedc4.1342092497.git.phrdina@redhat.com> <4FFF106F.5070603@redhat.com> <5003CCEF.6070200@redhat.com> <50044365.7080208@redhat.com> In-Reply-To: <50044365.7080208@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 3/4] qapi: Convert delvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Pavel Hrdina , qemu-devel@nongnu.org Am 16.07.2012 18:37, schrieb Eric Blake: > On 07/16/2012 02:12 AM, Pavel Hrdina wrote: >> On 07/12/2012 07:59 PM, Eric Blake wrote: >>> On 07/12/2012 10:55 AM, Pavel Hrdina wrote: >>>> Signed-off-by: Pavel Hrdina >>>> --- >>>> hmp-commands.hx | 2 +- >>>> hmp.c | 10 ++++++++++ >>>> hmp.h | 1 + >>>> qapi-schema.json | 17 +++++++++++++++++ >>>> qmp-commands.hx | 24 ++++++++++++++++++++++++ >>>> savevm.c | 21 +++++++++++---------- >>>> sysemu.h | 1 - >>>> 7 files changed, 64 insertions(+), 12 deletions(-) >>>> + >>>> +## >>>> +# @delvm: >>> This name is worse than 'loadvm' or 'savevm', in that we are NOT >>> deleting the entire vm, but a named snapshot stored within the vm. >>> Would naming it 'delete-vm-snapshot' make more sense (in which case the >>> others might make more sense as 'save-vm-snapshot' and >>> 'load-vm-snapshot')? >>> >> This naming looks nice. I definitely agree that it could be >> save-vm-snapshot, load-vm-snapshot, delete-vm-snapshot and >> query-vm-snapshots. > > On seeing that spelled out, I wonder if the '-vm' is just noise; where > we could use 'query-snapshots' instead of 'query-vm-snapshots'. Then > again, we already have 'blockdev-snapshot-sync', which is an entirely > different snapshot (just a block device, rather than the entire VM), so > dropping -vm is probably a bad idea. Anyone else want to chime in on > the bikeshed painting discussion of the best QMP name? Sure. ;-) If there is a blockdev-snapshot-sync, then the counterparts for the whole VM shouldn't be called load/save/del-vm-snapshot, but vm-snapshot-load/save/del. And possibly add a -sync as well. Kevin