[Qemu-devel] [PATCH] qemu-options.hx: Fix set_password and expire_password description

[Qemu-devel] [PATCH] qemu-options.hx: Fix set_password and expire_password description

[Pavel Hrdina]

From: Michal Novotny <minovotn@redhat.com>

The description for set_password and expire_password commands is
incomplete. This patch fixes the man page that is being generated
to match the real behaviour of these functions.

Signed-off-by: Michal Novotny <minovotn@redhat.com>
---
 qemu-options.hx |   17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index ecf7ca1..679e3ca 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1030,8 +1030,21 @@ is a TCP port number, not a display number.
 @item password
 
 Require that password based authentication is used for client connections.
-The password must be set separately using the @code{change} command in the
-@ref{pcsys_monitor}
+
+The password must be set separately using the @code{set_password} command in
+the @ref{pcsys_monitor}. The syntax to change your password is:
+@code{set_password <protocol> <password>} where <protocol> could be either
+"vnc" or "spice".
+
+If you would like to change <protocol> password expiration, you should use
+@code{expire_password <protocol> <expiration-time>} where expiration time could
+be one of the following options: now, never, +seconds or UNIX time of
+expiration, e.g. +60 to make password expire in 60 seconds, or 1335196800
+to make password expire on "Mon Apr 23 12:00:00 EDT 2012" (UNIX time for this
+date and time).
+
+You can also use keywords "now" or "never" for the expiration time to
+allow <protocol> password to expire immediately or never expire.
 
 @item tls
 
-- 
1.7.10.4

[Qemu-devel] [PATCH] qemu-options.hx: Improve -nodefaults description

[Pavel Hrdina]

From: Michal Novotny <minovotn@redhat.com>

This patch improves the description of -nodefaults QEMU command line
option by adding more information what is being disabled using this
command.

Signed-off-by: Michal Novotny <minovotn@redhat.com>
---
 qemu-options.hx |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index ecf7ca1..54ec14d 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2641,7 +2641,10 @@ DEF("nodefaults", 0, QEMU_OPTION_nodefaults, \
 STEXI
 @item -nodefaults
 @findex -nodefaults
-Don't create default devices.
+Don't create default devices. Normally, QEMU sets the default devices like serial
+port, parallel port, virtual console, monitor device, VGA adapter, floppy and
+CD-ROM drive and others. The @code{-nodefaults} option will disable all those
+default devices.
 ETEXI
 
 #ifndef _WIN32
-- 
1.7.10.4

[Qemu-devel] [PATCH] qemu-options.hx: Improve -{read|write}config options description

[Pavel Hrdina]

From: Michal Novotny <minovotn@redhat.com>

This is the patch to improve description for -{read|write}config
functions.

Signed-off-by: Michal Novotny <minovotn@redhat.com>
---
 qemu-options.hx |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index e15252e..97245a3 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2713,7 +2713,9 @@ DEF("readconfig", HAS_ARG, QEMU_OPTION_readconfig,
 STEXI
 @item -readconfig @var{file}
 @findex -readconfig
-Read device configuration from @var{file}.
+Read device configuration from @var{file}. This approach is useful when you want to spawn
+QEMU process with many command line options but you don't want to exceed the command line
+character limit.
 ETEXI
 DEF("writeconfig", HAS_ARG, QEMU_OPTION_writeconfig,
     "-writeconfig <file>\n"
@@ -2721,7 +2723,9 @@ DEF("writeconfig", HAS_ARG, QEMU_OPTION_writeconfig,
 STEXI
 @item -writeconfig @var{file}
 @findex -writeconfig
-Write device configuration to @var{file}.
+Write device configuration to @var{file}. The @var{file} can be either filename to save
+command line and device configuration into file or dash @code{-}) character to print the
+output to stdout. This can be later used as input file for @code{-readconfig} option.
 ETEXI
 DEF("nodefconfig", 0, QEMU_OPTION_nodefconfig,
     "-nodefconfig\n"
-- 
1.7.10.4

Re: [Qemu-devel] [PATCH] qemu-options.hx: Fix set_password and expire_password description

[Michal Novotny]

Sorry for spamming that much however I was confused why e-mail are
coming fine from Pavel Hrdina but not for me. That was the reason I
asked Pavel to send it for me as I didn't know my messages have to be
approved first because I have no recent activity on the list.

Sorry once again!
Michal

On 07/16/2012 01:05 PM, Michal Novotny wrote:
> The description for set_password and expire_password commands is
> incomplete. This patch fixes the man page that is being generated
> to match the real behaviour of these functions.
>
> Signed-off-by: Michal Novotny <minovotn@redhat.com>
> ---
>  qemu-options.hx |   17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index ecf7ca1..679e3ca 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1030,8 +1030,21 @@ is a TCP port number, not a display number.
>  @item password
>  
>  Require that password based authentication is used for client connections.
> -The password must be set separately using the @code{change} command in the
> -@ref{pcsys_monitor}
> +
> +The password must be set separately using the @code{set_password} command in
> +the @ref{pcsys_monitor}. The syntax to change your password is:
> +@code{set_password <protocol> <password>} where <protocol> could be either
> +"vnc" or "spice".
> +
> +If you would like to change <protocol> password expiration, you should use
> +@code{expire_password <protocol> <expiration-time>} where expiration time could
> +be one of the following options: now, never, +seconds or UNIX time of
> +expiration, e.g. +60 to make password expire in 60 seconds, or 1335196800
> +to make password expire on "Mon Apr 23 12:00:00 EDT 2012" (UNIX time for this
> +date and time).
> +
> +You can also use keywords "now" or "never" for the expiration time to
> +allow <protocol> password to expire immediately or never expire.
>  
>  @item tls
>  

-- 
Michal Novotny <minovotn@redhat.com>, RHCE, Red Hat
Virtualization | libvirt-php bindings | php-virt-control.org

Re: [Qemu-devel] [PATCH] qemu-options.hx: Fix set_password and expire_password description

[Kevin Wolf]

Am 16.07.2012 15:19, schrieb Pavel Hrdina:
> From: Michal Novotny <minovotn@redhat.com>
> 
> The description for set_password and expire_password commands is
> incomplete. This patch fixes the man page that is being generated
> to match the real behaviour of these functions.
> 
> Signed-off-by: Michal Novotny <minovotn@redhat.com>
> ---
>  qemu-options.hx |   17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)

This one probably qualifies for qemu-trivial, copied the list.

Kevin

> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index ecf7ca1..679e3ca 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1030,8 +1030,21 @@ is a TCP port number, not a display number.
>  @item password
>  
>  Require that password based authentication is used for client connections.
> -The password must be set separately using the @code{change} command in the
> -@ref{pcsys_monitor}
> +
> +The password must be set separately using the @code{set_password} command in
> +the @ref{pcsys_monitor}. The syntax to change your password is:
> +@code{set_password <protocol> <password>} where <protocol> could be either
> +"vnc" or "spice".
> +
> +If you would like to change <protocol> password expiration, you should use
> +@code{expire_password <protocol> <expiration-time>} where expiration time could
> +be one of the following options: now, never, +seconds or UNIX time of
> +expiration, e.g. +60 to make password expire in 60 seconds, or 1335196800
> +to make password expire on "Mon Apr 23 12:00:00 EDT 2012" (UNIX time for this
> +date and time).
> +
> +You can also use keywords "now" or "never" for the expiration time to
> +allow <protocol> password to expire immediately or never expire.
>  
>  @item tls
>