From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrCYt-0005pH-IT for qemu-devel@nongnu.org; Tue, 17 Jul 2012 14:31:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrCYs-00068I-7v for qemu-devel@nongnu.org; Tue, 17 Jul 2012 14:31:55 -0400 Received: from david.siemens.de ([192.35.17.14]:23888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrCYr-00068A-Un for qemu-devel@nongnu.org; Tue, 17 Jul 2012 14:31:54 -0400 Message-ID: <5005AF58.3070302@siemens.com> Date: Tue, 17 Jul 2012 20:30:48 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1342543307-10964-1-git-send-email-peter.maydell@linaro.org> <50059AF3.2050603@siemens.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] update-linux-headers.sh: Don't hard code list of architectures List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "qemu-devel@nongnu.org" , "patches@linaro.org" On 2012-07-17 19:34, Peter Maydell wrote: > On 17 July 2012 18:03, Jan Kiszka wrote: >> On 2012-07-17 18:41, Peter Maydell wrote: >>> Rather than hardcoding the list of architectures in the kernel >>> header update script, just import headers for every architecture >>> which supports KVM. This reduces the number of QEMU files which >>> need to be updated to add support for a new KVM architecture. >>> It also means we won't break if the kernel drops support for >>> an architecture in the future. >>> >>> Signed-off-by: Peter Maydell >>> --- >>> I'd like this for ARM, obviously. NB that this change will mean we'll >>> pick up the ia64 kvm headers next time somebody does a kernel header >>> update; this seems harmless (and perhaps even useful?). ia64 'make >>> headers_install' is a bit noisy as of 3.5-rc5 but succeeds anyway. >> >> IA64 KVM support is dead and may be removed at some point from the >> kernel. What about blacklisting it here already to avoid that noise? > > It's only noisy for the developer who runs the script, and if Developers are also human that may hate seeing this mess. :) > we blacklist it then we'll have to update the script again to > remove it from the blacklist when it finally dies. We /can/ clean this up then, but there will be no urgent need. > > I don't feel very strongly about it, though, so I can add an > > # Blacklist architectures which have KVM headers but are actually dead > if [ "$arch" = "ia64" ]; then > continue > fi > > to the patch if you want. Yes, I would prefer doing this. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux