From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49391)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SrRLD-0007vC-Cc
	for qemu-devel@nongnu.org; Wed, 18 Jul 2012 06:18:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SrRL9-0007PB-8l
	for qemu-devel@nongnu.org; Wed, 18 Jul 2012 06:18:47 -0400
Received: from goliath.siemens.de ([192.35.17.28]:30053)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SrRL8-0007Ol-W8
	for qemu-devel@nongnu.org; Wed, 18 Jul 2012 06:18:43 -0400
Message-ID: <50068D7D.8040108@siemens.com>
Date: Wed, 18 Jul 2012 12:18:37 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1342606269-12527-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1342606269-12527-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] update-linux-headers.sh: Don't hard code
	list of architectures
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "patches@linaro.org" <patches@linaro.org>

On 2012-07-18 12:11, Peter Maydell wrote:
> Rather than hardcoding the list of architectures in the kernel
> header update script, just import headers for every architecture
> which supports KVM (with a blacklist exception for ia64 which
> has KVM headers but is dead). This reduces the number of QEMU
> files which need to be updated to add support for a new KVM
> architecture.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Acked-by: Jan Kiszka <jan.kiszka@siemens.com>

> ---
> Changes v1->v2:
>  * added a blacklist for ia64, to avoid noise and importing
>    a pointless set of headers that will get dropped later
> 
>  scripts/update-linux-headers.sh |   16 +++++++++++++++-
>  1 files changed, 15 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
> index 9d2a4bc..57ce69f 100755
> --- a/scripts/update-linux-headers.sh
> +++ b/scripts/update-linux-headers.sh
> @@ -28,7 +28,21 @@ if [ -z "$output" ]; then
>      output="$PWD"
>  fi
>  
> -for arch in x86 powerpc s390; do
> +# This will pick up non-directories too (eg "Kconfig") but we will
> +# ignore them in the next loop.
> +ARCHLIST=$(cd "$linux/arch" && echo *)
> +
> +for arch in $ARCHLIST; do
> +    # Discard anything which isn't a KVM-supporting architecture
> +    if ! [ -e "$linux/arch/$arch/include/asm/kvm.h" ]; then
> +        continue
> +    fi
> +
> +    # Blacklist architectures which have KVM headers but are actually dead
> +    if [ "$arch" = "ia64" ]; then
> +        continue
> +    fi
> +
>      make -C "$linux" INSTALL_HDR_PATH="$tmpdir" SRCARCH=$arch headers_install
>  
>      rm -rf "$output/linux-headers/asm-$arch"
> 


-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux