From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrUN7-0003PA-Ru for qemu-devel@nongnu.org; Wed, 18 Jul 2012 09:33:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrUMx-0003Ac-0I for qemu-devel@nongnu.org; Wed, 18 Jul 2012 09:32:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrUMw-0003AR-OU for qemu-devel@nongnu.org; Wed, 18 Jul 2012 09:32:46 -0400 Message-ID: <5006BAF6.6040101@redhat.com> Date: Wed, 18 Jul 2012 15:32:38 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1342617786-22107-1-git-send-email-wdongxu@linux.vnet.ibm.com> In-Reply-To: <1342617786-22107-1-git-send-email-wdongxu@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] qemu-img: correct size parsers and help message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dong Xu Wang Cc: qemu-devel@nongnu.org, riegamaths@gmail.com Am 18.07.2012 15:23, schrieb Dong Xu Wang: > qemu-img not only suports k/K/M/G/T/b, but also supports m/g/t/B. So correct > it in help message. > > Also use the same parser in parse_option_size function. This is not what the patch does. It uses a parser that seems slightly more compatible with strtosz_suffix() than before, but it still doesn't use the same one. It really should call strtosz_suffix() instead of implementing a parser here. Kevin