From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrUjV-00064a-1s for qemu-devel@nongnu.org; Wed, 18 Jul 2012 09:56:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrUjP-000249-6Y for qemu-devel@nongnu.org; Wed, 18 Jul 2012 09:56:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrUjO-00023r-Ut for qemu-devel@nongnu.org; Wed, 18 Jul 2012 09:55:59 -0400 Message-ID: <5006C05C.2080809@redhat.com> Date: Wed, 18 Jul 2012 15:55:40 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <4FFA9C30.2070201@linux.vnet.ibm.com> <4FFAA0C3.3080703@redhat.com> <4FFBB7FB.3070303@linux.vnet.ibm.com> <4FFBD6F1.90403@redhat.com> <20120713091611.GC15503@stefanha-thinkpad.localdomain> <4FFFEF8E.5080705@redhat.com> <50000793.2020401@redhat.com> <5003CDC6.2040103@linux.vnet.ibm.com> <5003CE8B.20804@redhat.com> <500678F7.1030705@linux.vnet.ibm.com> <5006BF71.60405@suse.de> In-Reply-To: <5006BF71.60405@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Anthony Liguori , Stefan Hajnoczi , Michael Tokarev , =?UTF-8?B?TGx1w61z?= , qemu-devel@nongnu.org, Blue Swirl , Stefan Weil , Hannes Reinecke , Paolo Bonzini , Wenchao Xia Am 18.07.2012 15:51, schrieb Andreas F=C3=A4rber: > Am 18.07.2012 10:51, schrieb Wenchao Xia: >> Hi, following is API draft, prototypes were taken from qemu/block.h, >> and the API prefix is changed frpm bdrv to qbdrvs, to declare related >> object is BlockDriverState, not BlockDriver. [...] After the refactoring that Markus is working on it won't refer to a BlockDriverState, but to a BlockBackend. (And changes like this make quite clear why the internals of the current block layer are not suitable as a public API. The API needs to be defined in a separate layer than can abstract such changes away.) > So let the bikeshedding begin: ;) >=20 > What about qbds_ prefix rather than qbdrvs_? I find the proposed mixtur= e > of acronym (q for QEMU, b for Block, s for State) and abbreviation (drv > as in Driver) a bit ugly. >=20 > Or just simply go for qblock - might be better memorable. :) Yes, something like qblk that isn't tied to internals sounds better. Kevin