From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrVRn-0005qs-20 for qemu-devel@nongnu.org; Wed, 18 Jul 2012 10:41:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrVRf-0000gO-N8 for qemu-devel@nongnu.org; Wed, 18 Jul 2012 10:41:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrVRf-0000gE-Ap for qemu-devel@nongnu.org; Wed, 18 Jul 2012 10:41:43 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6IEfgHe006548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Jul 2012 10:41:42 -0400 Message-ID: <5006CB25.8080207@redhat.com> Date: Wed, 18 Jul 2012 08:41:41 -0600 From: Eric Blake MIME-Version: 1.0 References: <1342621904-25303-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1342621904-25303-1-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig01DE361FC08EF8B7844C9E22" Subject: Re: [Qemu-devel] [PATCH] improve scripts/make-release List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig01DE361FC08EF8B7844C9E22 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/18/2012 08:31 AM, Gerd Hoffmann wrote: > 'make dist' creates a tarball for the current checkout. > 'make qemu-${version}.tar.bz2' creates a tarball for git tag v${version= }. >=20 > Signed-off-by: Gerd Hoffmann > --- > Makefile | 5 ++--- > scripts/make-release | 8 +++++++- > 2 files changed, 9 insertions(+), 4 deletions(-) > +++ b/scripts/make-release > @@ -12,11 +12,17 @@ > =20 > src=3D"$1" > version=3D"$2" > +if test "$version" =3D ""; then test ! "$version" is less typing, and still POSIX compliant. > + commit=3D$(git describe --long) > + version=3D"${commit#v}" Sticking with my earlier theme started against Anthony's original implementation of this script, in complaining about inconsistent shell quoting styles, it might look nicer to favor minimal quoting: commit=3D$(git describe --long) version=3D${commit#v} or maximal quoting: commit=3D"$(git describe --long)" version=3D"${commit#v}" rather than an ad hoc mix. But as that is cosmetic, and does not impact functionality, you have my: Reviewed-by: Eric Blake --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig01DE361FC08EF8B7844C9E22 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQBsslAAoJEKeha0olJ0NqPMQIAK+eaxFbpYtu4/SNECp+Gh67 Do60Mm2Re8gjrZ/8feKPDX+igUgi9QmzY59rhrCMFajgY3poDJuNKVvEn/EVYgRE 7jZ9kikp/r9PZsgc49cDG7ouBAWHbQnH2HypoyVxobm3tY3q+HVxIG55s+aBpxKC U+04t1fqRrnkjyjVHEBTR3rs3G73N38gyogmzxiX8LhPO9hPdQUEHl5+Llktn6U/ K9H+RL2Qk8PkqRJahRqOJM9uMioqh+RdcRJhGNmscRFoZBZwwkDivyZAa5coDuhc UnOXdg+fb1zHkOfigIGWxi0zb2kmfveLwnjLwBn4ZqrUpyth1iXPz2oki4FYiXw= =7qaN -----END PGP SIGNATURE----- --------------enig01DE361FC08EF8B7844C9E22--