From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrpJl-0002nA-0X for qemu-devel@nongnu.org; Thu, 19 Jul 2012 07:54:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrpJk-0001mt-1X for qemu-devel@nongnu.org; Thu, 19 Jul 2012 07:54:52 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:57464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrpJj-0001mQ-DW for qemu-devel@nongnu.org; Thu, 19 Jul 2012 07:54:51 -0400 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 19 Jul 2012 17:24:48 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6JBsjP611796978 for ; Thu, 19 Jul 2012 17:24:45 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6JHPJ5n008511 for ; Fri, 20 Jul 2012 03:25:20 +1000 Message-ID: <5007F56D.90003@linux.vnet.ibm.com> Date: Thu, 19 Jul 2012 17:24:21 +0530 From: Harsh Bora MIME-Version: 1.0 References: <1342696051-22102-1-git-send-email-harsh@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v9 0/3] Simpletrace v2: Support multiple args, strings. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On 07/19/2012 05:22 PM, Stefan Hajnoczi wrote: > On Thu, Jul 19, 2012 at 12:07 PM, Harsh Prateek Bora > wrote: >> Existing simpletrace backend allows to trace at max 6 args and does not >> support strings. This newer tracelog format gets rid of fixed size records >> and therefore allows to trace variable number of args including strings. >> >> Sample trace: >> v9fs_version 0.000 tag=0xffff id=0x64 msize=0x2000 version=9P2000.L >> v9fs_version_return 6.705 tag=0xffff id=0x64 msize=0x2000 version=9P2000.L >> v9fs_attach 174.467 tag=0x1 id=0x68 fid=0x0 afid=0xffffffffffffffff >> uname=nobody aname= >> v9fs_attach_return 4720.454 tag=0x1 id=0x68 type=0xffffffffffffff80 >> version=0x4f2a4dd0 path=0x220ea6 >> >> v9: >> - Renamed TraceRecordHeader to TraceLogHeader as appropriate >> - Some more code cleanups > > We discussed this on IRC. v8 is already in my tracing tree and I have > sent a pull request. > > These code cleanups are nice but can be taken in a follow-up patch. > Sure, will do. Thanks once again, Harsh > Stefan >