From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34174)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Ss08l-00039b-FC
	for qemu-devel@nongnu.org; Thu, 19 Jul 2012 19:28:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Ss08k-0003Rf-0y
	for qemu-devel@nongnu.org; Thu, 19 Jul 2012 19:28:15 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:64381)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Ss08j-0003RT-TT
	for qemu-devel@nongnu.org; Thu, 19 Jul 2012 19:28:13 -0400
Received: by yenl1 with SMTP id l1so3546249yen.4
	for <qemu-devel@nongnu.org>; Thu, 19 Jul 2012 16:28:13 -0700 (PDT)
Message-ID: <5008980C.60809@codemonkey.ws>
Date: Thu, 19 Jul 2012 18:28:12 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <50082E7F.7030800@siemens.com>
In-Reply-To: <50082E7F.7030800@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] audio: Make PC speaker audio card
 available by default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 07/19/2012 10:57 AM, Jan Kiszka wrote:
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>

Broke the build.  I'm also confused about why this is necessary.

You can just set CONFIG_PCSPK=y in default-configs/${ARCH}.mak to enable it and 
indeed, it's enabled by default for a bunch of targets including x86_64.

So... I'm confused what this is fixing.  Since I suspect malc and Jan are 
asleep, I'm going to revert for now to fix the build.

I'll happily help fix whatever Jan was trying to fix tomorrow.

Regards,

Anthony Liguori

> ---
>   configure |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 106209a..42adc8d 100755
> --- a/configure
> +++ b/configure
> @@ -90,8 +90,8 @@ static="no"
>   sparc_cpu=""
>   cross_prefix=""
>   audio_drv_list=""
> -audio_card_list="ac97 es1370 sb16 hda"
> -audio_possible_cards="ac97 es1370 sb16 cs4231a adlib gus hda"
> +audio_card_list="ac97 es1370 sb16 hda pcspk"
> +audio_possible_cards="ac97 es1370 sb16 cs4231a adlib gus hda pcspk"
>   block_drv_whitelist=""
>   host_cc="gcc"
>   helper_cflags=""