From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ss71N-0006xz-AR for qemu-devel@nongnu.org; Fri, 20 Jul 2012 02:49:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ss71M-0003nm-6S for qemu-devel@nongnu.org; Fri, 20 Jul 2012 02:49:05 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:48492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ss71L-0003nh-Sf for qemu-devel@nongnu.org; Fri, 20 Jul 2012 02:49:04 -0400 Received: by pbbro12 with SMTP id ro12so5657830pbb.4 for ; Thu, 19 Jul 2012 23:49:03 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5008FF58.5050801@redhat.com> Date: Fri, 20 Jul 2012 08:48:56 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1342724013-1633-1-git-send-email-minyard@acm.org> In-Reply-To: <1342724013-1633-1-git-send-email-minyard@acm.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Third shot at adding IPMI to qemu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: minyard@acm.org Cc: qemu-devel@nongnu.org Il 19/07/2012 20:53, minyard@acm.org ha scritto: > Ok, everything passes through checkpatch without an error now. I have > added some tests to verify basic operation of the device, and I've > hacked in some documentation, though I'm not sure if it's in the proper > location, as I never got a response to my questions about it. > > I would have liked to add tests for the watchdog timer, but there > doesn't appear to be a way to intercept resets or NMIs in the test > framework. I reviewed the basic QOM plumbing and it looks ok. Paolo