From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ss7E9-0008C3-El for qemu-devel@nongnu.org; Fri, 20 Jul 2012 03:02:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ss7E8-0006ns-83 for qemu-devel@nongnu.org; Fri, 20 Jul 2012 03:02:17 -0400 Received: from mout.web.de ([212.227.17.12]:61656) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ss7E7-0006nY-VT for qemu-devel@nongnu.org; Fri, 20 Jul 2012 03:02:16 -0400 Message-ID: <50090269.7090604@web.de> Date: Fri, 20 Jul 2012 09:02:01 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <50082E7F.7030800@siemens.com> <5008980C.60809@codemonkey.ws> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigCDD82387DB31D453D7F2A862" Subject: Re: [Qemu-devel] [PATCH] audio: Make PC speaker audio card available by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc , Anthony Liguori Cc: qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigCDD82387DB31D453D7F2A862 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-07-20 02:01, malc wrote: > On Thu, 19 Jul 2012, Anthony Liguori wrote: >=20 >> On 07/19/2012 10:57 AM, Jan Kiszka wrote: >>> Signed-off-by: Jan Kiszka >> >> Broke the build. I'm also confused about why this is necessary. >=20 > It built fine here[1]. So was i, but... Yeah, sorry, was to quick to send a premature workaround instead of trying to understand what actually broke here. What happened is that pcspk is no longer selectable via -soundhw. And that is because CONFIG_PCSPK, used by arch_init.c to build the static soundhw arraw, is no longer selected at target built time. It became a host level define when we moved the speaker into hwlib. I will try to find some workaround at configure level. I guess, on the long run, we will have to refactor the audio backend to allow for runtime registration of drivers. Jan --------------enigCDD82387DB31D453D7F2A862 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlAJAmwACgkQitSsb3rl5xQVsACglSoeDKRDffABf1yryBF9iXnV fCIAoIaC0Ei4XrX9RZpBcxlTTbKm13zD =ouWx -----END PGP SIGNATURE----- --------------enigCDD82387DB31D453D7F2A862--