From: Gerd Hoffmann <kraxel@redhat.com>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: seabios@seabios.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH 2/2] lsi53c895a boot support
Date: Fri, 20 Jul 2012 09:33:05 +0200 [thread overview]
Message-ID: <500909B1.2060505@redhat.com> (raw)
In-Reply-To: <20120720005534.GC24578@morn.localdomain>
Hi,
>> + /* FIXME: probably not the best idea to have this on the stack ... */
>> + u32 script[] = {
>
> Several places in the code DMA to the stack already (usb-ehci,
> usb-uhci, ata).
My concern isn't DMA'ing to the stack, but the size of the script and
possible stack overruns. But maybe it is a moot point with the stack
switching added to seabios recently.
cheers,
Gerd
next prev parent reply other threads:[~2012-07-20 7:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 16:15 [Qemu-devel] [PATCH 0/2] scsi boot Gerd Hoffmann
2012-07-19 16:15 ` [Qemu-devel] [PATCH 1/2] usb attached scsi boot support Gerd Hoffmann
2012-07-20 0:51 ` [Qemu-devel] [SeaBIOS] " Kevin O'Connor
2012-07-19 16:15 ` [Qemu-devel] [PATCH 2/2] lsi53c895a " Gerd Hoffmann
2012-07-20 0:55 ` [Qemu-devel] [SeaBIOS] " Kevin O'Connor
2012-07-20 7:33 ` Gerd Hoffmann [this message]
2012-07-20 12:47 ` Kevin O'Connor
2012-07-20 13:39 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500909B1.2060505@redhat.com \
--to=kraxel@redhat.com \
--cc=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).