From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ss7i5-0004DF-Vr for qemu-devel@nongnu.org; Fri, 20 Jul 2012 03:33:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ss7i1-0006Gg-LI for qemu-devel@nongnu.org; Fri, 20 Jul 2012 03:33:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ss7i1-0006GS-E5 for qemu-devel@nongnu.org; Fri, 20 Jul 2012 03:33:09 -0400 Message-ID: <500909B1.2060505@redhat.com> Date: Fri, 20 Jul 2012 09:33:05 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1342714503-6673-1-git-send-email-kraxel@redhat.com> <1342714503-6673-3-git-send-email-kraxel@redhat.com> <20120720005534.GC24578@morn.localdomain> In-Reply-To: <20120720005534.GC24578@morn.localdomain> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH 2/2] lsi53c895a boot support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: seabios@seabios.org, qemu-devel@nongnu.org Hi, >> + /* FIXME: probably not the best idea to have this on the stack ... */ >> + u32 script[] = { > > Several places in the code DMA to the stack already (usb-ehci, > usb-uhci, ata). My concern isn't DMA'ing to the stack, but the size of the script and possible stack overruns. But maybe it is a moot point with the stack switching added to seabios recently. cheers, Gerd