From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>, Olaf Hering <OHering@suse.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] configure: Replace bash code by standard shell code
Date: Fri, 20 Jul 2012 14:28:26 +0200 [thread overview]
Message-ID: <50094EEA.6000801@suse.de> (raw)
In-Reply-To: <CAFEAcA81RGQE5meYmO0mCCBNTkk2igTu9DipDQvhgpqOQxH63Q@mail.gmail.com>
Am 17.07.2012 21:19, schrieb Peter Maydell:
> On 17 July 2012 20:07, Stefan Weil <sw@weilnetz.de> wrote:
>> If the user overrides CFLAGS, I expect that he/she will notice
>> that compilation fails and hopefully find the cause (only
>> expert users should override CFLAGS). Overriding -march=i486
>> might be useful to set -march=i686.
>>
>> Therefore it was not so obvious to me whether CFLAGS or
>> QEMU_CFLAGS was the better choice.
>
> Yes, I had to dig to find out the underlying principle
> distinguishing the two. Having found it I would like us to
> fix this in a way which respects that principle.
I was planning to pick up Olaf's patch doing just that but haven't got
around to it in time for v1.1. Olaf, do you have time to resubmit a
patch to upstream qemu-devel as requested by Peter and me?
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-07-20 12:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-15 18:34 [Qemu-devel] [PATCH 1/2] configure: Replace bash code by standard shell code Stefan Weil
2012-07-15 18:34 ` [Qemu-devel] [PATCH 2/2] configure: Fix errors in test for__sync_fetch_and_and Stefan Weil
2012-07-17 18:43 ` [Qemu-devel] [PATCH 1/2] configure: Replace bash code by standard shell code Peter Maydell
2012-07-17 19:07 ` Stefan Weil
2012-07-17 19:19 ` Peter Maydell
2012-07-20 12:28 ` Andreas Färber [this message]
2012-07-20 12:30 ` Peter Maydell
2012-07-20 12:35 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50094EEA.6000801@suse.de \
--to=afaerber@suse.de \
--cc=OHering@suse.com \
--cc=blauwirbel@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).