From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsCJq-0004Zd-Nb for qemu-devel@nongnu.org; Fri, 20 Jul 2012 08:28:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SsCJp-0003AK-Kj for qemu-devel@nongnu.org; Fri, 20 Jul 2012 08:28:30 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37818 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SsCJp-0003AA-Dm for qemu-devel@nongnu.org; Fri, 20 Jul 2012 08:28:29 -0400 Message-ID: <50094EEA.6000801@suse.de> Date: Fri, 20 Jul 2012 14:28:26 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1342377272-32511-1-git-send-email-sw@weilnetz.de> <5005B7F0.6070305@weilnetz.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] configure: Replace bash code by standard shell code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Olaf Hering Cc: Blue Swirl , Stefan Weil , qemu-devel@nongnu.org Am 17.07.2012 21:19, schrieb Peter Maydell: > On 17 July 2012 20:07, Stefan Weil wrote: >> If the user overrides CFLAGS, I expect that he/she will notice >> that compilation fails and hopefully find the cause (only >> expert users should override CFLAGS). Overriding -march=3Di486 >> might be useful to set -march=3Di686. >> >> Therefore it was not so obvious to me whether CFLAGS or >> QEMU_CFLAGS was the better choice. >=20 > Yes, I had to dig to find out the underlying principle > distinguishing the two. Having found it I would like us to > fix this in a way which respects that principle. I was planning to pick up Olaf's patch doing just that but haven't got around to it in time for v1.1. Olaf, do you have time to resubmit a patch to upstream qemu-devel as requested by Peter and me? Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg