* [Qemu-devel] [PATCH] alsa: fix configure detection of alsa
@ 2012-07-20 21:14 Anthony Liguori
2012-07-20 21:29 ` Stefan Weil
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Anthony Liguori @ 2012-07-20 21:14 UTC (permalink / raw)
To: qemu-devel; +Cc: Anthony Liguori
Handle is uninitialized which causes the configure check to fail.
Cc: malc <av1474@comtv.ru>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
configure | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index cef0a71..8335117 100755
--- a/configure
+++ b/configure
@@ -1888,7 +1888,7 @@ for drv in $audio_drv_list; do
case $drv in
alsa)
audio_drv_probe $drv alsa/asoundlib.h -lasound \
- "snd_pcm_t **handle; return snd_pcm_close(*handle);"
+ "snd_pcm_t **handle = NULL; return snd_pcm_close(*handle);"
libs_softmmu="-lasound $libs_softmmu"
;;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] alsa: fix configure detection of alsa
2012-07-20 21:14 [Qemu-devel] [PATCH] alsa: fix configure detection of alsa Anthony Liguori
@ 2012-07-20 21:29 ` Stefan Weil
2012-07-20 21:32 ` malc
2012-07-21 9:00 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Weil @ 2012-07-20 21:29 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
Am 20.07.2012 23:14, schrieb Anthony Liguori:
> Handle is uninitialized which causes the configure check to fail.
>
> Cc: malc<av1474@comtv.ru>
> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
> ---
> configure | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index cef0a71..8335117 100755
> --- a/configure
> +++ b/configure
> @@ -1888,7 +1888,7 @@ for drv in $audio_drv_list; do
> case $drv in
> alsa)
> audio_drv_probe $drv alsa/asoundlib.h -lasound \
> - "snd_pcm_t **handle; return snd_pcm_close(*handle);"
> + "snd_pcm_t **handle = NULL; return snd_pcm_close(*handle);"
> libs_softmmu="-lasound $libs_softmmu"
> ;;
>
>
See also http://patchwork.ozlabs.org/patch/171066/
Regards,
Stefan W.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] alsa: fix configure detection of alsa
2012-07-20 21:14 [Qemu-devel] [PATCH] alsa: fix configure detection of alsa Anthony Liguori
2012-07-20 21:29 ` Stefan Weil
@ 2012-07-20 21:32 ` malc
2012-07-21 9:00 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: malc @ 2012-07-20 21:32 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
On Fri, 20 Jul 2012, Anthony Liguori wrote:
> Handle is uninitialized which causes the configure check to fail.
>
http://patchwork.ozlabs.org/patch/171688/
Has an advantage of not expecting alsa/asoundlib.h including
stddef.h
> Cc: malc <av1474@comtv.ru>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
> configure | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index cef0a71..8335117 100755
> --- a/configure
> +++ b/configure
> @@ -1888,7 +1888,7 @@ for drv in $audio_drv_list; do
> case $drv in
> alsa)
> audio_drv_probe $drv alsa/asoundlib.h -lasound \
> - "snd_pcm_t **handle; return snd_pcm_close(*handle);"
> + "snd_pcm_t **handle = NULL; return snd_pcm_close(*handle);"
> libs_softmmu="-lasound $libs_softmmu"
> ;;
>
>
--
mailto:av1474@comtv.ru
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] alsa: fix configure detection of alsa
2012-07-20 21:14 [Qemu-devel] [PATCH] alsa: fix configure detection of alsa Anthony Liguori
2012-07-20 21:29 ` Stefan Weil
2012-07-20 21:32 ` malc
@ 2012-07-21 9:00 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2012-07-21 9:00 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
On 20 July 2012 22:14, Anthony Liguori <aliguori@us.ibm.com> wrote:
> Handle is uninitialized which causes the configure check to fail.
Do keep up at the back :-). I posted a whole series earlier this
week which among other things fixes a whole pile of these
-Werror related configure issues.
http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg02311.html
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-21 9:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-20 21:14 [Qemu-devel] [PATCH] alsa: fix configure detection of alsa Anthony Liguori
2012-07-20 21:29 ` Stefan Weil
2012-07-20 21:32 ` malc
2012-07-21 9:00 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).