From: Paolo Bonzini <pbonzini@redhat.com>
To: benoit.canet@gmail.com
Cc: stefanha@gmail.com, "Benoît Canet" <benoit@irqsave.net>,
qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 1/3] block: Add bdrv_have_block_jobs() so migration code abort if needed.
Date: Mon, 23 Jul 2012 12:02:58 +0200 [thread overview]
Message-ID: <500D2152.70701@redhat.com> (raw)
In-Reply-To: <1342812757-2651-2-git-send-email-benoit@irqsave.net>
Il 20/07/2012 21:32, benoit.canet@gmail.com ha scritto:
> +bool bdrv_have_block_jobs(void)
> +{
> + BlockDriverState *bs;
> +
> + QTAILQ_FOREACH(bs, &bdrv_states, list) {
> + if (bs->job || bdrv_in_use(bs)) {
> + return true;
> + }
> + bdrv_close(bs);
Why close the device here?
Paolo
> + }
> +
> + return false;
> +}
> +
next prev parent reply other threads:[~2012-07-23 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 19:32 [Qemu-devel] [PATCH 0/3] Block migration when streaming block jobs are running benoit.canet
2012-07-20 19:32 ` [Qemu-devel] [PATCH 1/3] block: Add bdrv_have_block_jobs() so migration code abort if needed benoit.canet
2012-07-23 10:02 ` Paolo Bonzini [this message]
2012-07-23 10:25 ` Benoît Canet
2012-07-20 19:32 ` [Qemu-devel] [PATCH 2/3] qerror: Add error telling that streaming blocks migration benoit.canet
2012-07-20 19:32 ` [Qemu-devel] [PATCH 3/3] migration: block migration when streaming block jobs are running benoit.canet
2012-07-23 9:55 ` Stefan Hajnoczi
2012-07-23 10:17 ` Benoît Canet
2012-07-23 10:43 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500D2152.70701@redhat.com \
--to=pbonzini@redhat.com \
--cc=benoit.canet@gmail.com \
--cc=benoit@irqsave.net \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).