From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53125)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1StFTt-0000Ea-Ti
	for qemu-devel@nongnu.org; Mon, 23 Jul 2012 06:03:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1StFTo-0004uA-8V
	for qemu-devel@nongnu.org; Mon, 23 Jul 2012 06:03:13 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:37043)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1StFTn-0004u4-Sx
	for qemu-devel@nongnu.org; Mon, 23 Jul 2012 06:03:08 -0400
Received: by pbbro12 with SMTP id ro12so10515402pbb.4
	for <qemu-devel@nongnu.org>; Mon, 23 Jul 2012 03:03:07 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <500D2152.70701@redhat.com>
Date: Mon, 23 Jul 2012 12:02:58 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1342812757-2651-1-git-send-email-benoit@irqsave.net>
	<1342812757-2651-2-git-send-email-benoit@irqsave.net>
In-Reply-To: <1342812757-2651-2-git-send-email-benoit@irqsave.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] block: Add bdrv_have_block_jobs() so
 migration code abort if needed.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: benoit.canet@gmail.com
Cc: stefanha@gmail.com, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= <benoit@irqsave.net>, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

Il 20/07/2012 21:32, benoit.canet@gmail.com ha scritto:
> +bool bdrv_have_block_jobs(void)
> +{
> +    BlockDriverState *bs;
> +
> +    QTAILQ_FOREACH(bs, &bdrv_states, list) {
> +        if (bs->job || bdrv_in_use(bs)) {
> +            return true;
> +        }
> +        bdrv_close(bs);

Why close the device here?

Paolo

> +    }
> +
> +    return false;
> +}
> +