From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StYoz-0003IV-QE for qemu-devel@nongnu.org; Tue, 24 Jul 2012 02:42:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1StYoz-0000vn-1O for qemu-devel@nongnu.org; Tue, 24 Jul 2012 02:42:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StYoy-0000vi-Pg for qemu-devel@nongnu.org; Tue, 24 Jul 2012 02:42:16 -0400 Message-ID: <500E43C0.9080608@redhat.com> Date: Tue, 24 Jul 2012 08:42:08 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1342785709-3152-1-git-send-email-stefanha@linux.vnet.ibm.com> <1342785709-3152-17-git-send-email-stefanha@linux.vnet.ibm.com> <500DCFEA.1000603@redhat.com> In-Reply-To: <500DCFEA.1000603@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 16/16] hub: add the support for hub own flow control List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Zhi Yong Wu , Zhi Yong Wu , Stefan Hajnoczi , qemu-devel@nongnu.org Il 24/07/2012 00:27, Laszlo Ersek ha scritto: > This seems to consolidate net_hub_receive_iov()'s retval with that of > net_hub_receive(), but may I ask why it used to be calculated differently? Because until this patch was introduced, net/hub.c had a TODO about the return values of net_hub_receive_*(). Probably this patch could be squashed earlier in the series, but it's not paramount. Paolo