From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51655)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Stbnc-0006Lj-04
	for qemu-devel@nongnu.org; Tue, 24 Jul 2012 05:53:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1StbnW-0001os-5t
	for qemu-devel@nongnu.org; Tue, 24 Jul 2012 05:53:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:18577)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1StbnV-0001ol-UK
	for qemu-devel@nongnu.org; Tue, 24 Jul 2012 05:52:58 -0400
Message-ID: <500E706E.8030405@redhat.com>
Date: Tue, 24 Jul 2012 11:52:46 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1343053380-12133-1-git-send-email-benoit@irqsave.net>
In-Reply-To: <1343053380-12133-1-git-send-email-benoit@irqsave.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V4 0/3] Block migration if any of the block
 device is busy
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: benoit.canet@gmail.com
Cc: stefanha@gmail.com, pbonzini@redhat.com, =?UTF-8?B?QmVub8OudCBD?= =?UTF-8?B?YW5ldA==?= <benoit@irqsave.net>, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

Am 23.07.2012 16:22, schrieb benoit.canet@gmail.com:
> From: Beno=C3=AEt Canet <benoit@irqsave.net>
>=20
> This patchset is designed to avoid starting a live migration while any =
of
> the block device is busy.
>=20
> Tested with the following sequence:
>=20
> QEMU 1.1.50 monitor - type 'help' for more information
> (qemu) block_stream virtio0 1k
> (qemu) migrate tcp:localhost:4444
> migrate: Migration is blocked by streaming
> (qemu)  block_job_cancel virtio0
> (qemu)  migrate tcp:localhost:4444
> migrate: Connection can not be completed immediately
> (qemu)=20
> =3D> migration then succeed

Maybe I'm missing the obvious, but why? Migration will stop the
streaming if it isn't restarted explicitly on the destination, but I
think that's expected.

Also, there are migration blockers. Wouldn't it be better to use them
instead of adding more special-case code to migration.c?

Kevin