qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>,
	Dhaval Giani <dhaval.giani@gmail.com>,
	linux-kernel@vger.kernel.org, Borislav Petkov <bp@amd64.org>,
	qemu-devel@nongnu.org, "Franch Ch. Eigler" <fche@redhat.com>,
	Ingo Molnar <mingo@redhat.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Anthony Liguori <anthony@codemonkey.ws>,
	yrl.pp-manager.tt@hitachi.com, Amit Shah <amit.shah@redhat.com>,
	virtualization@lists.linux-foundation.org,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [RFC PATCH 0/6] virtio-trace: Support virtio-trace
Date: Tue, 24 Jul 2012 20:03:38 +0900	[thread overview]
Message-ID: <500E810A.4030309@hitachi.com> (raw)
In-Reply-To: <CAJSP0QW_2JJ0nf=NW0y30VSid2HSxaqb=mRGV8CTtAKj0ujDWw@mail.gmail.com>

(2012/07/24 19:02), Stefan Hajnoczi wrote:
> On Tue, Jul 24, 2012 at 3:36 AM, Yoshihiro YUNOMAE
> <yoshihiro.yunomae.ez@hitachi.com> wrote:
>> The performance of each method is compared as follows:
>>  [1] Native
>>      - only recording trace data to ring-buffer on a guest
>>  [2] Virtio-trace
>>      - running a trace agent on a guest
>>      - a reader on a host opens FIFO using cat command
>>  [3] IVRing
>>      - A SystemTap script in a guest records trace data to IVRing.
>>        -- probe points are same as ftrace.
>>  [4] Virtio-serial(normal)
>>      - A reader(using cat) on a guest output trace data to a host using
>>        standard output via virtio-serial.
> 
> The first time I read this I thought you are adding a new virtio-trace
> device.  But it looks like this series really add splice support to
> virtio-console and that yields a big performance improvement when
> sending trace_pipe_raw.

Yes, sorry for the confusion. Actually this is an enhancement of
virtio-serial. I'm working with Yoshihiro on this feature.

> Guest ftrace is useful and I like this.  Have you thought about
> controlling ftrace from the host?  Perhaps a command could be added to
> the QEMU guest agent which basically invokes trace-cmd/perf.

As you can see, guest trace-agent can be controlled via a
control channel. In our scenario, host tools can control that
instead of guest one.

We are considering that exporting the tracing part of guest's
debugfs to host via another virtio-serial channel by using
9pfs, so that the host tools can refer that.

(In this scenario, guest trace-agent will also provide 9pfs server.
Since it means that the agent can handle writing a special file,
trace-agent can be controlled via the special file on exported
debugfs.)

Of course, this also requires modifying trace-cmd/perf to accept
some options like guest-debugfs mount point, guest's serial
channel pipe (or unix socket?), etc. However, it will be a small
change.

Thank you,

-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com

  reply	other threads:[~2012-07-24 11:03 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-24  2:36 [Qemu-devel] [RFC PATCH 0/6] virtio-trace: Support virtio-trace Yoshihiro YUNOMAE
2012-07-24  2:37 ` [Qemu-devel] [RFC PATCH 1/6] virtio/console: Add splice_write support Yoshihiro YUNOMAE
2012-08-09  9:00   ` Amit Shah
2012-08-09  9:12     ` Masami Hiramatsu
2012-07-24  2:37 ` [Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer Yoshihiro YUNOMAE
2012-08-09  9:03   ` Amit Shah
2012-08-09  9:24     ` Borislav Petkov
2012-08-09  9:24     ` Masami Hiramatsu
2012-08-09  9:55       ` Amit Shah
2012-08-09  9:58         ` Avi Kivity
2012-08-09 10:14           ` Amit Shah
2012-08-09 12:35       ` Steven Rostedt
2012-07-24  2:37 ` [Qemu-devel] [RFC PATCH 3/6] virtio/console: Wait until the port is ready on splice Yoshihiro YUNOMAE
2012-07-24  2:37 ` [Qemu-devel] [RFC PATCH 4/6] ftrace: Allow stealing pages from pipe buffer Yoshihiro YUNOMAE
2012-07-30 22:12   ` Steven Rostedt
2012-07-24  2:37 ` [Qemu-devel] [RFC PATCH 5/6] virtio/console: Allocate scatterlist according to the current pipe size Yoshihiro YUNOMAE
2012-07-24  2:37 ` [Qemu-devel] [RFC PATCH 6/6] tools: Add guest trace agent as a user tool Yoshihiro YUNOMAE
2012-07-24  3:27 ` [Qemu-devel] [RFC PATCH 0/6] virtio-trace: Support virtio-trace Masami Hiramatsu
2012-07-24 10:02 ` Stefan Hajnoczi
2012-07-24 11:03   ` Masami Hiramatsu [this message]
2012-07-24 11:19     ` Yoshihiro YUNOMAE
2012-07-24 13:41       ` Stefan Hajnoczi
2012-07-25  9:13         ` Yoshihiro YUNOMAE
2012-07-26 10:52           ` Stefan Hajnoczi
2012-07-24 13:43     ` Stefan Hajnoczi
2012-07-24 20:26 ` Blue Swirl
2012-07-25  8:15   ` Masami Hiramatsu
2012-07-27 18:58     ` Blue Swirl
2012-07-26 11:35 ` Amit Shah
2012-07-27  8:55   ` Yoshihiro YUNOMAE
2012-07-27  9:43     ` Amit Shah
2012-07-31  0:52       ` Yoshihiro YUNOMAE
2012-08-09 10:16 ` Amit Shah
2012-08-21  2:17   ` Rusty Russell
2012-08-21  5:09     ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=500E810A.4030309@hitachi.com \
    --to=masami.hiramatsu.pt@hitachi.com \
    --cc=amit.shah@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=arnd@arndb.de \
    --cc=bp@amd64.org \
    --cc=dhaval.giani@gmail.com \
    --cc=fche@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rostedt@goodmis.org \
    --cc=srikar@linux.vnet.ibm.com \
    --cc=stefanha@gmail.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=yoshihiro.yunomae.ez@hitachi.com \
    --cc=yrl.pp-manager.tt@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).