From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com,
qemu-devel@nongnu.org, avi@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] build: get dependency file directories from object file names
Date: Tue, 24 Jul 2012 13:43:00 +0200 [thread overview]
Message-ID: <500E8A44.5070705@redhat.com> (raw)
In-Reply-To: <500E8935.3010603@suse.de>
Il 24/07/2012 13:38, Andreas Färber ha scritto:
>> > +$(foreach var,$(nested-vars), $(eval \
>> > + -include $(addsuffix *.d, $(sort $(dir $($(var)))))))
>> > endef
>> >
> Are you sure? Dependencies are not guaranteed to be in one of the
> unnested variables, thought we ran into some issues earlier... In
> particular I'm thinking of tcg/*.d and of *.d in .user, .target, those
> that are actually recursed into.
obj-y is a nested variable:
nested-vars += obj-y
# This resolves all nested paths, so it must come last
include $(SRC_PATH)/Makefile.objs
$(dir $(obj-y)) contains tcg/ and from there you get tcg/*.d.
The only makefile that doesn't use the nesting mechanism is tests/Makefile.
Paolo
next prev parent reply other threads:[~2012-07-24 11:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 14:40 [Qemu-devel] [PATCH 0/2] build: get all *.d files Paolo Bonzini
2012-07-11 14:40 ` [Qemu-devel] [PATCH 1/2] build: include qapi-generated/ files in qga/Makefile.objs Paolo Bonzini
2012-07-11 15:25 ` Michael Roth
2012-07-11 15:28 ` Paolo Bonzini
2012-07-11 16:00 ` Michael Roth
2012-07-11 14:40 ` [Qemu-devel] [PATCH 2/2] build: get dependency file directories from object file names Paolo Bonzini
2012-07-24 11:38 ` Andreas Färber
2012-07-24 11:43 ` Paolo Bonzini [this message]
2012-07-24 11:53 ` Andreas Färber
2012-07-24 12:02 ` Paolo Bonzini
2012-07-24 11:17 ` [Qemu-devel] [PATCH 0/2] build: get all *.d files Paolo Bonzini
2012-07-28 12:16 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500E8A44.5070705@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).