From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StdW6-0008IM-Gb for qemu-devel@nongnu.org; Tue, 24 Jul 2012 07:43:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1StdW5-0007ZQ-3S for qemu-devel@nongnu.org; Tue, 24 Jul 2012 07:43:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StdW4-0007ZH-Rq for qemu-devel@nongnu.org; Tue, 24 Jul 2012 07:43:05 -0400 Message-ID: <500E8A44.5070705@redhat.com> Date: Tue, 24 Jul 2012 13:43:00 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1342017621-12650-1-git-send-email-pbonzini@redhat.com> <1342017621-12650-3-git-send-email-pbonzini@redhat.com> <500E8935.3010603@suse.de> In-Reply-To: <500E8935.3010603@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] build: get dependency file directories from object file names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, avi@redhat.com Il 24/07/2012 13:38, Andreas F=E4rber ha scritto: >> > +$(foreach var,$(nested-vars), $(eval \ >> > + -include $(addsuffix *.d, $(sort $(dir $($(var))))))) >> > endef >> >=20 > Are you sure? Dependencies are not guaranteed to be in one of the > unnested variables, thought we ran into some issues earlier... In > particular I'm thinking of tcg/*.d and of *.d in .user, .target, those > that are actually recursed into. obj-y is a nested variable: nested-vars +=3D obj-y # This resolves all nested paths, so it must come last include $(SRC_PATH)/Makefile.objs $(dir $(obj-y)) contains tcg/ and from there you get tcg/*.d. The only makefile that doesn't use the nesting mechanism is tests/Makefil= e. Paolo