From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] qom: Reject attempts to add a property that already exists
Date: Tue, 24 Jul 2012 16:56:14 +0200 [thread overview]
Message-ID: <500EB78E.1050001@redhat.com> (raw)
In-Reply-To: <1343140218-23741-1-git-send-email-peter.maydell@linaro.org>
Il 24/07/2012 16:30, Peter Maydell ha scritto:
> + ObjectProperty *prop;
> +
> + QTAILQ_FOREACH(prop, &obj->properties, node) {
> + if (strcmp(prop->name, name) == 0) {
> + /* This is always a bug in the caller */
> + fprintf(stderr, "attempt to set duplicate property %s on object\n",
> + name);
> + assert(0);
abort();
That's all I have to say. :)
Paolo
> + }
> + }
> +
> + prop = g_malloc0(sizeof(*prop));
prev parent reply other threads:[~2012-07-24 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 14:30 [Qemu-devel] [PATCH] qom: Reject attempts to add a property that already exists Peter Maydell
2012-07-24 14:56 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500EB78E.1050001@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).