From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StsV0-0004nX-GN for qemu-devel@nongnu.org; Tue, 24 Jul 2012 23:42:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1StsUz-0007bV-Dw for qemu-devel@nongnu.org; Tue, 24 Jul 2012 23:42:58 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:38763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StsUz-0007bP-7L for qemu-devel@nongnu.org; Tue, 24 Jul 2012 23:42:57 -0400 Received: from /spool/local by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 24 Jul 2012 21:42:56 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id E68F73E40039 for ; Wed, 25 Jul 2012 03:42:52 +0000 (WET) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6P3grYu287624 for ; Tue, 24 Jul 2012 21:42:53 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6P3grJ1004123 for ; Tue, 24 Jul 2012 21:42:53 -0600 Message-ID: <500F6B3B.3070404@linux.vnet.ibm.com> Date: Tue, 24 Jul 2012 23:42:51 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1343048885-1701-1-git-send-email-coreyb@linux.vnet.ibm.com> <500E906F.5040709@redhat.com> In-Reply-To: <500E906F.5040709@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/6] file descriptor passing using fd sets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, libvir-list@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, eblake@redhat.com On 07/24/2012 08:09 AM, Kevin Wolf wrote: > Am 23.07.2012 15:07, schrieb Corey Bryant: >> Corey Bryant (6): >> qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg >> qapi: Introduce add-fd, remove-fd, query-fdsets >> monitor: Clean up fd sets on monitor disconnect >> block: Convert open calls to qemu_open >> block: Convert close calls to qemu_close >> block: Enable qemu_open/close to work with fd sets >> >> block/raw-posix.c | 42 ++++----- >> block/raw-win32.c | 6 +- >> block/vdi.c | 5 +- >> block/vmdk.c | 25 +++--- >> block/vpc.c | 4 +- >> block/vvfat.c | 16 ++-- >> cutils.c | 5 ++ >> monitor.c | 244 ++++++++++++++++++++++++++++++++++++++++++++++++++++- >> monitor.h | 4 + >> osdep.c | 141 +++++++++++++++++++++++++++++++ >> qapi-schema.json | 97 +++++++++++++++++++++ >> qemu-char.c | 10 ++- >> qemu-common.h | 2 + >> qemu-tool.c | 12 +++ >> qmp-commands.hx | 121 ++++++++++++++++++++++++++ >> savevm.c | 4 +- >> 16 files changed, 684 insertions(+), 54 deletions(-) > > Apart from the points I commented on in patch 6, and what Eric and you > found, this looks good to me. > > Kevin > Great, thanks for the review! -- Regards, Corey