From: Paolo Bonzini <pbonzini@redhat.com>
To: liu ping fan <qemulist@gmail.com>
Cc: kvm@vger.kernel.org, Stefan Hajnoczi <stefanha@gmail.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PATCH 4/5] qom: delay DeviceState's reclaim to main-loop
Date: Wed, 25 Jul 2012 10:22:17 +0200 [thread overview]
Message-ID: <500FACB9.70209@redhat.com> (raw)
In-Reply-To: <CAJnKYQmivACCkC5muGAW41fUoYguO9gzQ70zECZj-5MgdeGxYA@mail.gmail.com>
Il 25/07/2012 10:16, liu ping fan ha scritto:
> > It's not clear how to me. The only reference to devices from an
> > iohandler/bh/timer can be in the opaque. Now, if you have a
> > iohandler/bh/timer whose opaque is a DeviceState, you should bump the
> > refcount before setting it up, and unref after tearing it down.
>
> Yes, I admit refcnt is a good solution, but I think it means that we
> will fix it with each device's bh. And this way seems lazy.
Most of the time the bh/timer/iohandler is created in the init function,
and deleted in the exit function, so in this case the lifecycle is even
easier to manage.
Looking at your patch again, it seems like you're implementing a
poor-man RCU. So that's fine for a proof-of-concept, but let's replace
it with real RCU sooner or later.
Paolo
next prev parent reply other threads:[~2012-07-25 8:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 3:31 [Qemu-devel] [PATCH 0/5] prepare unplug out of protection of global lock Liu Ping Fan
2012-07-25 3:31 ` [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it Liu Ping Fan
2012-07-25 9:08 ` Paolo Bonzini
2012-07-26 12:56 ` liu ping fan
2012-07-26 13:00 ` Avi Kivity
2012-07-26 13:14 ` liu ping fan
2012-07-26 13:15 ` Avi Kivity
2012-07-26 13:21 ` liu ping fan
2012-07-26 13:46 ` Avi Kivity
2012-07-25 3:31 ` [Qemu-devel] [PATCH 2/5] exec.c: use refcnt to protect device during dispatching Liu Ping Fan
2012-07-25 7:43 ` Stefan Hajnoczi
2012-07-25 8:12 ` liu ping fan
2012-07-25 9:18 ` Paolo Bonzini
2012-07-26 13:00 ` liu ping fan
2012-07-25 10:58 ` Avi Kivity
2012-07-25 12:27 ` Avi Kivity
2012-07-26 13:06 ` liu ping fan
2012-07-26 13:13 ` Avi Kivity
2012-07-25 3:31 ` [Qemu-devel] [PATCH 3/5] hotplug: introduce qdev_unplug_ack() to remove device from views Liu Ping Fan
2012-07-25 10:58 ` Avi Kivity
2012-07-25 3:31 ` [Qemu-devel] [PATCH 4/5] qom: delay DeviceState's reclaim to main-loop Liu Ping Fan
2012-07-25 7:03 ` Stefan Hajnoczi
2012-07-25 7:37 ` Paolo Bonzini
2012-07-25 8:16 ` liu ping fan
2012-07-25 8:22 ` Paolo Bonzini [this message]
2012-07-25 8:17 ` liu ping fan
2012-07-25 3:31 ` [Qemu-devel] [PATCH 5/5] e1000: using new interface--unmap to unplug Liu Ping Fan
2012-07-25 7:12 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500FACB9.70209@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).