From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StzHL-0005NQ-3m for qemu-devel@nongnu.org; Wed, 25 Jul 2012 06:57:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1StzHI-0000Ni-Up for qemu-devel@nongnu.org; Wed, 25 Jul 2012 06:57:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StzHI-0000NY-N3 for qemu-devel@nongnu.org; Wed, 25 Jul 2012 06:57:16 -0400 Message-ID: <500FD101.1080200@redhat.com> Date: Wed, 25 Jul 2012 12:57:05 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1343203902-10524-1-git-send-email-benoit@irqsave.net> <1343203902-10524-3-git-send-email-benoit@irqsave.net> In-Reply-To: <1343203902-10524-3-git-send-email-benoit@irqsave.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V2 2/3] block: Use bdrv_get_backing_file_ancestors_count() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: benoit.canet@gmail.com Cc: =?UTF-8?B?QmVub8OudCBD?= =?UTF-8?B?YW5ldA==?= , stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, stefanha@linux.vnet.ibm.com Am 25.07.2012 10:11, schrieb benoit.canet@gmail.com: > From: Beno=C3=AEt Canet >=20 > Use the dedicated counting function in qmp_query_block in order to > propagate the backing file count to HMP. >=20 > Signed-off-by: Benoit Canet > --- > block.c | 2 ++ > qapi-schema.json | 9 ++++++--- > 2 files changed, 8 insertions(+), 3 deletions(-) >=20 > diff --git a/block.c b/block.c > index 03e0860..4aa3ea9 100644 > --- a/block.c > +++ b/block.c > @@ -2448,6 +2448,8 @@ BlockInfoList *qmp_query_block(Error **errp) > if (bs->backing_file[0]) { > info->value->inserted->has_backing_file =3D true; > info->value->inserted->backing_file =3D g_strdup(bs->b= acking_file); > + info->value->inserted->backing_file_ancestors_count =3D > + bdrv_get_backing_file_ancestors_count(bs); > } > =20 > if (bs->io_limits_enabled) { > diff --git a/qapi-schema.json b/qapi-schema.json > index a92adb1..eb72c16 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -398,6 +398,8 @@ > # > # @backing_file: #optional the name of the backing file (for copy-on-w= rite) > # > +# @backing_file_ancestors_count: #optional the count of ancestors back= ing files (for copy-on-write) > +# Why is it optional? Would it be omitted rather than set to 0 if there are no backing files? Could also use a "(since: 1.2)" note. Kevin