From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34267)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1StzJC-0007c6-J0
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 06:59:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1StzJ6-0000wl-Rj
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 06:59:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48860)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1StzJ6-0000wh-KA
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 06:59:08 -0400
Message-ID: <500FD174.10204@redhat.com>
Date: Wed, 25 Jul 2012 12:59:00 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1343203902-10524-1-git-send-email-benoit@irqsave.net>
	<1343203902-10524-4-git-send-email-benoit@irqsave.net>
In-Reply-To: <1343203902-10524-4-git-send-email-benoit@irqsave.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V2 3/3] hmp: show the backing file
	ancestors count
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: benoit.canet@gmail.com
Cc: =?UTF-8?B?QmVub8OudCBD?= =?UTF-8?B?YW5ldA==?= <benoit@irqsave.net>, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, stefanha@linux.vnet.ibm.com

Am 25.07.2012 10:11, schrieb benoit.canet@gmail.com:
> From: Beno=C3=AEt Canet <benoit@irqsave.net>
>=20
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
>  hmp.c |    2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/hmp.c b/hmp.c
> index 6b72a64..19dcb65 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -227,6 +227,8 @@ void hmp_info_block(Monitor *mon)
>              if (info->value->inserted->has_backing_file) {
>                  monitor_printf(mon, " backing_file=3D");
>                  monitor_print_filename(mon, info->value->inserted->bac=
king_file);
> +                monitor_printf(mon, " backing_file_ancestors_count=3D%=
" PRId64,
> +                    info->value->inserted->backing_file_ancestors_coun=
t);

This is not what a user interface looks like. Maybe something like "%d
backing files", and omit the message if there aren't any backing files.

Kevin