From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Stzfw-0005MB-Ca for Qemu-devel@nongnu.org; Wed, 25 Jul 2012 07:22:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Stzfv-0007Ss-8Y for Qemu-devel@nongnu.org; Wed, 25 Jul 2012 07:22:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Stzfv-0007So-0y for Qemu-devel@nongnu.org; Wed, 25 Jul 2012 07:22:43 -0400 Message-ID: <500FD6FD.1050004@redhat.com> Date: Wed, 25 Jul 2012 13:22:37 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1343203902-10524-1-git-send-email-benoit@irqsave.net> <1343203902-10524-4-git-send-email-benoit@irqsave.net> <500FD174.10204@redhat.com> <20120725111756.GC12455@irqsave.net> In-Reply-To: <20120725111756.GC12455@irqsave.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V2 3/3] hmp: show the backing file ancestors count List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Beno=EEt_Canet?= Cc: Qemu-devel@nongnu.org Am 25.07.2012 13:17, schrieb Beno=EEt Canet: > Le Wednesday 25 Jul 2012 =E0 12:59:00 (+0200), Kevin Wolf a =E9crit : >> Am 25.07.2012 10:11, schrieb benoit.canet@gmail.com: >>> From: Beno=EEt Canet >>> >>> Signed-off-by: Benoit Canet >>> --- >>> hmp.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/hmp.c b/hmp.c >>> index 6b72a64..19dcb65 100644 >>> --- a/hmp.c >>> +++ b/hmp.c >>> @@ -227,6 +227,8 @@ void hmp_info_block(Monitor *mon) >>> if (info->value->inserted->has_backing_file) { >>> monitor_printf(mon, " backing_file=3D"); >>> monitor_print_filename(mon, info->value->inserted->b= acking_file); >>> + monitor_printf(mon, " backing_file_ancestors_count=3D= %" PRId64, >>> + info->value->inserted->backing_file_ancestors_co= unt); >> >> This is not what a user interface looks like. Maybe something like "%d >> backing files", and omit the message if there aren't any backing files. >=20 > The whole line of info block look like this: > virtio0: removable=3D0 io-status=3Dok file=3D/home/benoit/images/gruik.= qed backing_file=3D/home/benoit/images/snap.qed backing_file_ancestors_co= unt=3D1 ro=3D0 drv=3Dqed encrypted=3D0 bps=3D0 bps_rd=3D0 bps_wr=3D0 iops= =3D0 iops_rd=3D0 iops_wr=3D0 > Again I tried to make something coherent. I see. I wasn't really aware that it's already that bad today. The whole output of this command should be changed, but it's not in the scope of your series. > It's already ommited when there is no backing file (the field is option= al). Yeah, sorry, I missed the context. Kevin