From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su0Ju-000695-NC for qemu-devel@nongnu.org; Wed, 25 Jul 2012 08:04:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su0Jp-0002Dr-Q6 for qemu-devel@nongnu.org; Wed, 25 Jul 2012 08:04:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su0Jp-0002Dh-IV for qemu-devel@nongnu.org; Wed, 25 Jul 2012 08:03:57 -0400 Message-ID: <500FE08E.7020901@redhat.com> Date: Wed, 25 Jul 2012 14:03:26 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1343203902-10524-1-git-send-email-benoit@irqsave.net> <1343203902-10524-3-git-send-email-benoit@irqsave.net> <500FD101.1080200@redhat.com> <20120725111519.GB12455@irqsave.net> <500FD633.9000507@redhat.com> <20120725114217.GD12455@irqsave.net> In-Reply-To: <20120725114217.GD12455@irqsave.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V2 2/3] block: Use bdrv_get_backing_file_ancestors_count() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Beno=EEt_Canet?= Cc: benoit.canet@gmail.com, stefanha@linux.vnet.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com Am 25.07.2012 13:42, schrieb Beno=EEt Canet: > Le Wednesday 25 Jul 2012 =E0 13:19:15 (+0200), Kevin Wolf a =E9crit : >> Am 25.07.2012 13:15, schrieb Beno=EEt Canet: >>> Le Wednesday 25 Jul 2012 =E0 12:57:05 (+0200), Kevin Wolf a =E9crit : >>>> Am 25.07.2012 10:11, schrieb benoit.canet@gmail.com: >>>>> From: Beno=EEt Canet >>>>> >>>>> Use the dedicated counting function in qmp_query_block in order to >>>>> propagate the backing file count to HMP. >>>>> >>>>> Signed-off-by: Benoit Canet >>>>> --- >>>>> block.c | 2 ++ >>>>> qapi-schema.json | 9 ++++++--- >>>>> 2 files changed, 8 insertions(+), 3 deletions(-) >>>>> >>>>> diff --git a/block.c b/block.c >>>>> index 03e0860..4aa3ea9 100644 >>>>> --- a/block.c >>>>> +++ b/block.c >>>>> @@ -2448,6 +2448,8 @@ BlockInfoList *qmp_query_block(Error **errp) >>>>> if (bs->backing_file[0]) { >>>>> info->value->inserted->has_backing_file =3D true; >>>>> info->value->inserted->backing_file =3D g_strdup(b= s->backing_file); >>>>> + info->value->inserted->backing_file_ancestors_coun= t =3D >>>>> + bdrv_get_backing_file_ancestors_count(bs); >>>>> } >>>>> =20 >>>>> if (bs->io_limits_enabled) { >>>>> diff --git a/qapi-schema.json b/qapi-schema.json >>>>> index a92adb1..eb72c16 100644 >>>>> --- a/qapi-schema.json >>>>> +++ b/qapi-schema.json >>>>> @@ -398,6 +398,8 @@ >>>>> # >>>>> # @backing_file: #optional the name of the backing file (for copy-= on-write) >>>>> # >>>>> +# @backing_file_ancestors_count: #optional the count of ancestors = backing files (for copy-on-write) >>>>> +# >>>> >>>> Why is it optional? Would it be omitted rather than set to 0 if ther= e >>>> are no backing files? >>> >>> I made it optional because backing_file=3Dsomething is optional. >>> So It seemed coherent to make it also optional. >>> However I'll change it if you confirm it should be changed. >> >> The reason why the backing file naem is optional is because there is n= o >> valid value to use when there is no backing file. But for the count, 0 >> makes perfect sense. >=20 > Should I also make is alway present in the HMP output ? I think I would hide it in HMP if it is 0, but this isn't a very strong opinion. You can do it as you like. Kevin