From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42583)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Su1U3-0004uI-FB
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 09:18:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Su1Tx-0007pA-Mr
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 09:18:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29526)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Su1Tx-0007p3-Eo
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 09:18:29 -0400
Message-ID: <500FF268.402@redhat.com>
Date: Wed, 25 Jul 2012 15:19:36 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1343144119-18757-1-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <1343144119-18757-1-git-send-email-stefanha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code
	into net/hub.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Zhi Yong Wu <wuzhy@cn.ibm.com>

On 07/24/12 17:35, Stefan Hajnoczi wrote:

> v2:
>  * Change int64_t and unsigned int mess to int which is what VLAN IDs are today [Laszlo]
>  * Remove bogus error_set() -> qerror_report() merge artifact [Laszlo]
>  * Use net_hub_id_for_client(nc, NULL) == 0 instead of adding net_hub_port_peer_nc() [Laszlo]
>  * Fix stray print_net_client(..., NetClientState *vc) argument name [Laszlo]
>  * Consistently update vlan -> peer argument name [Laszlo]
>  * Drop spurious closesocket(fd), probably merge conflict [Stefan]

I checked the interdiffs and my v1 comments.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>