From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su3hA-0000PV-IU for qemu-devel@nongnu.org; Wed, 25 Jul 2012 11:40:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su3h8-0003er-SX for qemu-devel@nongnu.org; Wed, 25 Jul 2012 11:40:16 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52450 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su3h8-0003dT-II for qemu-devel@nongnu.org; Wed, 25 Jul 2012 11:40:14 -0400 Message-ID: <50101356.4030305@suse.de> Date: Wed, 25 Jul 2012 17:40:06 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1343222672-25312-1-git-send-email-peter.maydell@linaro.org> <1343222672-25312-7-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1343222672-25312-7-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 6/6] kvm: Add documentation comment for kvm_irqchip_in_kernel() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: patches@linaro.org, Marcelo Tosatti , qemu-devel@nongnu.org, Alexander Graf , Jan Kiszka , Avi Kivity Am 25.07.2012 15:24, schrieb Peter Maydell: > Now we've cleared out the architecture-independent uses of > kvm_irqchip_in_kernel(), we can add a doc comment describing > what it means. >=20 > Signed-off-by: Peter Maydell > --- > kvm.h | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) If you've cleared the arch-independent uses, can't it be moved out of the generic kvm.h? Otherwise if just the commit message is confusing me: >=20 > diff --git a/kvm.h b/kvm.h > index 1449795..ae9df2d 100644 > --- a/kvm.h > +++ b/kvm.h > @@ -30,6 +30,17 @@ extern bool kvm_msi_via_irqfd_allowed; > =20 > #if defined CONFIG_KVM || !defined NEED_CPU_H > #define kvm_enabled() (kvm_allowed) Could we add a white line here... > +/** > + * kvm_irqchip_in_kernel: > + * > + * Returns: true if the user asked us to create an in-kernel > + * irqchip via the "kernel_irqchip=3Don" machine option. > + * What this actually means is architecture and machine model > + * specific: on PC, for instance, it means that the LAPIC, > + * IOAPIC and PIT are all in kernel. This function should never > + * be used from generic target-independent code: use one of the > + * following functions or some other specific check instead. > + */ > #define kvm_irqchip_in_kernel() (kvm_kernel_irqchip) ...and here, to better group the macros and their documentation? Andreas > /** > * kvm_async_interrupt_injection: >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg