From: Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Alexander Graf <agraf@suse.de>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq
Date: Wed, 25 Jul 2012 19:00:46 +0300 [thread overview]
Message-ID: <5010182E.7090506@redhat.com> (raw)
In-Reply-To: <CAFEAcA_h17HDhtV2UPD=WEQQU3q-TyhjZfBpPe1m_OxLqt6jRw@mail.gmail.com>
On 07/25/2012 06:56 PM, Peter Maydell wrote:
> On 25 July 2012 16:55, Avi Kivity <avi@redhat.com> wrote:
>> On 07/25/2012 06:53 PM, Jan Kiszka wrote:
>>> We don't have a synchronous function anymore, it's part of the pre-run
>>> code of x86 IIRC.
>>
>> Right. There's a DPRINTF() there that talks about injection, too. So I
>> think this patch can be dropped.
>
> The main purpose of the patch is to remove 'irqchip' from the
> function name, because the function isn't restricted to use
> with in-kernel irqchips.
kvm_set_irq(), then.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-07-25 16:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 13:24 [Qemu-devel] [PATCH 0/6] split out uses of kvm_irqchip_in_kernel() Peter Maydell
2012-07-25 13:24 ` [Qemu-devel] [PATCH 1/6] kvm: Decouple 'interrupt injection is async' from 'kernel irqchip' Peter Maydell
2012-07-25 15:41 ` Jan Kiszka
2012-07-25 13:24 ` [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq Peter Maydell
2012-07-25 15:43 ` Jan Kiszka
2012-07-25 15:47 ` Avi Kivity
2012-07-25 15:53 ` Jan Kiszka
2012-07-25 15:55 ` Avi Kivity
2012-07-25 15:56 ` Peter Maydell
2012-07-25 15:58 ` Jan Kiszka
2012-07-25 16:09 ` Peter Maydell
2012-07-25 16:11 ` Jan Kiszka
2012-07-25 16:18 ` Peter Maydell
2012-07-25 16:24 ` Peter Maydell
2012-07-25 16:28 ` Jan Kiszka
2012-07-25 16:36 ` Avi Kivity
2012-07-25 16:41 ` Peter Maydell
2012-07-25 16:56 ` Jan Kiszka
2012-07-25 16:00 ` Avi Kivity [this message]
2012-07-25 15:55 ` Peter Maydell
2012-07-25 16:02 ` Avi Kivity
2012-07-25 13:24 ` [Qemu-devel] [PATCH 3/6] kvm: Move kvm_allows_irq0_override() to target-i386 Peter Maydell
2012-07-25 15:44 ` Jan Kiszka
2012-07-25 13:24 ` [Qemu-devel] [PATCH 4/6] kvm: Don't assume irqchip-in-kernel implies irqfds Peter Maydell
2012-07-25 15:47 ` Jan Kiszka
2012-07-25 15:52 ` Peter Maydell
2012-07-25 15:54 ` Jan Kiszka
2012-07-25 13:24 ` [Qemu-devel] [PATCH 5/6] kvm: Don't assume irqchip implies MSI routing via irqfds Peter Maydell
2012-07-25 15:49 ` Jan Kiszka
2012-07-25 13:24 ` [Qemu-devel] [PATCH 6/6] kvm: Add documentation comment for kvm_irqchip_in_kernel() Peter Maydell
2012-07-25 15:40 ` Andreas Färber
2012-07-25 16:47 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5010182E.7090506@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=jan.kiszka@siemens.com \
--cc=mtosatti@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).