From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su42h-0003C3-BW for qemu-devel@nongnu.org; Wed, 25 Jul 2012 12:02:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su42f-00029i-SP for qemu-devel@nongnu.org; Wed, 25 Jul 2012 12:02:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su42f-00028h-KE for qemu-devel@nongnu.org; Wed, 25 Jul 2012 12:02:29 -0400 Message-ID: <50101890.3090607@redhat.com> Date: Wed, 25 Jul 2012 19:02:24 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1343222672-25312-1-git-send-email-peter.maydell@linaro.org> <1343222672-25312-3-git-send-email-peter.maydell@linaro.org> <50101519.4020108@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Alexander Graf , Marcelo Tosatti , Jan Kiszka , qemu-devel@nongnu.org, patches@linaro.org On 07/25/2012 06:55 PM, Peter Maydell wrote: >> The correct terminology would be: >> interrupt injection: synchronous, in-vcpu, after all masks have been >> evaluated. Straight into the vein. >> interrupt queueing: asynchronous, extra-vcpu, before any masks >> >> Since interrupt queueing (well that name isn't perfect for level >> triggered interrupts, since it may not queue anything...) is the norm, I >> think it's better to keep the set_irq() naming and mark the synchronous >> interrupt injection function as special. > > So just call this 'kvm_set_irq()' ? Yes. -- error compiling committee.c: too many arguments to function