From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58200)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Su4SA-0002aK-9W
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 12:28:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Su4S6-0002Ll-9m
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 12:28:50 -0400
Received: from thoth.sbs.de ([192.35.17.2]:21256)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Su4S5-0002Ji-V6
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 12:28:46 -0400
Message-ID: <50101EBA.7040405@siemens.com>
Date: Wed, 25 Jul 2012 18:28:42 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1343222672-25312-1-git-send-email-peter.maydell@linaro.org>
	<1343222672-25312-3-git-send-email-peter.maydell@linaro.org>
	<50101519.4020108@redhat.com>	<5010166A.5070201@siemens.com>
	<501016D9.2050101@redhat.com>
	<CAFEAcA_h17HDhtV2UPD=WEQQU3q-TyhjZfBpPe1m_OxLqt6jRw@mail.gmail.com>
	<501017B8.8040507@siemens.com>
	<CAFEAcA-O4iN-kzixseirwhPm-hENpAe6Cz3w1mh6yquxjfsHtg@mail.gmail.com>
	<50101ABE.4080801@siemens.com>
	<CAFEAcA_AGzk6C6BZ6wtdG_kaXECWGzjUp8LLqqosLb5v1NWrxg@mail.gmail.com>
	<CAFEAcA_pKHFicYQkADZZD3Czm2gG-fZA-zPFQwxJE2D6S5tOrg@mail.gmail.com>
In-Reply-To: <CAFEAcA_pKHFicYQkADZZD3Czm2gG-fZA-zPFQwxJE2D6S5tOrg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to
	kvm_inject_async_irq
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Alexander Graf <agraf@suse.de>, "patches@linaro.org" <patches@linaro.org>, Avi Kivity <avi@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 2012-07-25 18:24, Peter Maydell wrote:
> On 25 July 2012 17:18, Peter Maydell <peter.maydell@linaro.org> wrote:
>> Not in the sense of "you need to KVM_CREATE_IRQCHIP it",
> 
> ...incidentally I was thinking about maybe moving kvm_irqchip_create()
> from being called by kvm_init() to being called by the device
> init function for the relevant irqchip (particularly we'll need
> to do that if we adopt Avi's suggestion of having a parameter
> to KVM_CREATE_IRQCHIP to specify a particular kind of irqchip).
> But that's more invasive surgery so I didn't want to do it yet.

This won't fly as irchip affects the whole orchestra (vcpus & irqchip
stubs in user space), at least on x86, and has to be called in the
current order. That's also why kernel_irqchip is a machine options, not
an option of one of the many device models.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux