From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su4bL-0007Ru-TX for qemu-devel@nongnu.org; Wed, 25 Jul 2012 12:38:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su4bH-00058p-S8 for qemu-devel@nongnu.org; Wed, 25 Jul 2012 12:38:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su4bH-00058b-IS for qemu-devel@nongnu.org; Wed, 25 Jul 2012 12:38:15 -0400 Message-ID: <501020E1.3010104@redhat.com> Date: Wed, 25 Jul 2012 10:37:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343219765-12297-1-git-send-email-benoit@irqsave.net> <1343219765-12297-3-git-send-email-benoit@irqsave.net> In-Reply-To: <1343219765-12297-3-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigE701132E43DF2FD5D8C7C222" Subject: Re: [Qemu-devel] [PATCH V3 2/3] block: Use bdrv_get_backing_file_ancestors_count() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: benoit.canet@gmail.com Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, pbonzini@redhat.com, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE701132E43DF2FD5D8C7C222 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/25/2012 06:36 AM, benoit.canet@gmail.com wrote: > From: Beno=C3=AEt Canet >=20 > Use the dedicated counting function in qmp_query_block in order to > propagate the backing file count to HMP. >=20 > Signed-off-by: Benoit Canet > +++ b/qapi-schema.json > @@ -398,6 +398,8 @@ > # > # @backing_file: #optional the name of the backing file (for copy-on-w= rite) > # > +# @backing_file_ancestors_count: #the count of ancestors backing files= (since: 1.2) s/ancestors/ancestor's/ ? s/#// You are making it sound like this is the count of ancestors of the backing file (that is, 'base <- sn1 <- sn2' would have a count of 1, since there is 1 ancestor of the backing file sn1; and what if I have no backing file?), rather than a count of ancestors of this file (base has a count of 0, base <- sn1 has a count of 1). Maybe a better wording is: @backing_file_depth: number of files in the backing file chain (since: 1.= 2) --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigE701132E43DF2FD5D8C7C222 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQECDhAAoJEKeha0olJ0Nqe60H/RW8ePDCudJhGerVmEIrptat eq3Qy6cbWq3XgkLUlh5XDBoZVtmyex8m0DcVvdqvbiLi2fs/Vcbj7NVlSLPBt9J4 uL15+3hoqbrKK/tx0XkjrzP/mrHj5Ho35ymoc0ABCDH/9A3JkWRE3Wc558y+Z9+P pmMDwliwtJshrMyVbKCdSGGNWVWs4phaedbYzyOFdA0G+mk0dqOmeuLuba8yvFZ7 ZVKmZDQr9UePJHBcyMKPVLyAFrasQ4HXrU8GMfPTXyfCzloPzgV+ZKsSsVujfNA9 XhHHi2i+DHxsZiIU+XBTfG/IEElzlGwnBuOd14qYVfj84rsaKZDqAJlX055TcRo= =E2fb -----END PGP SIGNATURE----- --------------enigE701132E43DF2FD5D8C7C222--