From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su4fb-0001Za-UQ for qemu-devel@nongnu.org; Wed, 25 Jul 2012 12:42:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su4fW-0006Wr-7Z for qemu-devel@nongnu.org; Wed, 25 Jul 2012 12:42:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su4fV-0006Wn-U7 for qemu-devel@nongnu.org; Wed, 25 Jul 2012 12:42:38 -0400 Message-ID: <5010212F.7030304@redhat.com> Date: Wed, 25 Jul 2012 10:39:11 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343219765-12297-1-git-send-email-benoit@irqsave.net> <1343219765-12297-3-git-send-email-benoit@irqsave.net> In-Reply-To: <1343219765-12297-3-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigDAA687205E62DB9F1EF00F6E" Subject: Re: [Qemu-devel] [PATCH V3 2/3] block: Use bdrv_get_backing_file_ancestors_count() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: benoit.canet@gmail.com Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, pbonzini@redhat.com, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDAA687205E62DB9F1EF00F6E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/25/2012 06:36 AM, benoit.canet@gmail.com wrote: > +++ b/qapi-schema.json > @@ -398,6 +398,8 @@ > # > # @backing_file: #optional the name of the backing file (for copy-on-w= rite) > # > +# @backing_file_ancestors_count: #the count of ancestors backing files= (since: 1.2) > +# > # @encrypted: true if the backing device is encrypted > # > # @bps: total throughput limit in bytes per second is specified > @@ -418,9 +420,10 @@ > ## > { 'type': 'BlockDeviceInfo', > 'data': { 'file': 'str', 'ro': 'bool', 'drv': 'str', > - '*backing_file': 'str', 'encrypted': 'bool', > - 'bps': 'int', 'bps_rd': 'int', 'bps_wr': 'int', > - 'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int'} } > + '*backing_file': 'str', 'backing_file_ancestors_count': 'i= nt', I hit send too soon. QMP prefers '-' over '_', so the new parameter should be 'backing-file-ancestors-count' (or with my proposal, 'backing-file-depth'). Yes, this particular struct has some _ for historical reasons, but that doesn't mean that new elements must share the misery. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigDAA687205E62DB9F1EF00F6E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQECEvAAoJEKeha0olJ0Nqj4oH/AmcAsnNmaSBxoX6og3I2hFF YE/7QaUq5JHcKrSZX5W5TyQSBiXJWNZeG6TTF/qPFFoNmlZwZzgyeGCI2/WdNKxD SefmEI6gHq0dfCxBEYjJV0XtiduLUAGXcXyFbaaVdlvGGviYZjwgQqx+RtBSYD4Q UX07NEY4dIoDiAAL69KIz0ySSh5LpZKvMQpaAQEuyIiqr6Horue7BSwp/WWwW1wq 5esipm09jb2NCulJ+rB7i5PcMdDxd1CHJfWWOXPTIIpeRhI/rd1VYqMhlvP9UWTn RQHo7ao8zF+K+Yv+AsXgQ3WumfqwbvGVhUVck9WGeEF+7UgbkdkaitnB2fGI17Q= =rU+j -----END PGP SIGNATURE----- --------------enigDAA687205E62DB9F1EF00F6E--