From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su4jX-0006L8-Hb for qemu-devel@nongnu.org; Wed, 25 Jul 2012 12:46:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su4jR-0007Vv-PL for qemu-devel@nongnu.org; Wed, 25 Jul 2012 12:46:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40281) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su4jR-0007Vr-G7 for qemu-devel@nongnu.org; Wed, 25 Jul 2012 12:46:41 -0400 Message-ID: <501022EF.2090700@redhat.com> Date: Wed, 25 Jul 2012 10:46:39 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343233543-18561-1-git-send-email-aliguori@us.ibm.com> <1343233543-18561-2-git-send-email-aliguori@us.ibm.com> <5010228E.7070704@redhat.com> In-Reply-To: <5010228E.7070704@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig9192B671F904F639872CEE73" Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-opts: introduce a function to compare option names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anthony Liguori , Luiz Capitulino , qemu-devel@nongnu.org, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9192B671F904F639872CEE73 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/25/2012 10:45 AM, Eric Blake wrote: > On 07/25/2012 10:25 AM, Anthony Liguori wrote: >> We don't use the standard C functions for conversion because we don't = want to >> depend on the user's locale. All option names in QEMU are en_US in pl= ain ASCII. >=20 >> =20 >> +static int opt_tolower(int ch) >> +{ >> + if (ch >=3D 'A' && ch <=3D 'Z') { >> + return 'a' + (ch - 'A'); P.S. This is not portable to EBCDIC, but I guess we don't care about compilation of qemu on a non-ASCII machine, so my review still stands. > Reviewed-by: Eric Blake >=20 --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig9192B671F904F639872CEE73 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQECLwAAoJEKeha0olJ0NqK4IH/il6cdbvqN6SDaoz7BNEiMKg A0sGok7ic1uJ0nCTeSoWnhfrM3+QcncX8Z+0ONQntZh5PJLymXMwJtAu6u+a84BI W6GcGIAz4n6qyWa5j24IAQpldUcA1SMb6Xzud0EyqyA385xPcIwq9rccWt3hwAVA Un79taBacfjdvrPL4lMW0QHjF4ZrfMPsxa+c97dJC58/CrX2fHaPUZLaTc7OdgW9 ioGdGVwzRoKX+zKFuWpQgnS4vmBFGSiofi+A3DVMFhCGouibNAnWTfke/HtfLpvj HayZRRnFDG00+wXOsA7/bA1y7wjWxut1FtKinbQDyCNSDKRDmS5xqdxYpmMtaQg= =cFUh -----END PGP SIGNATURE----- --------------enig9192B671F904F639872CEE73--