From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su5nk-0006c7-6O for qemu-devel@nongnu.org; Wed, 25 Jul 2012 13:55:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su5nf-0003ej-L3 for qemu-devel@nongnu.org; Wed, 25 Jul 2012 13:55:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su5nf-0003e6-D0 for qemu-devel@nongnu.org; Wed, 25 Jul 2012 13:55:07 -0400 Message-ID: <501032EA.8050307@redhat.com> Date: Wed, 25 Jul 2012 11:54:50 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343218884-14980-1-git-send-email-stefanha@linux.vnet.ibm.com> <1343218884-14980-8-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1343218884-14980-8-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigC57A12B44E4DBFF8F4FFD5AA" Subject: Re: [Qemu-devel] [PATCH v2 7/7] qemu-iotests: add 039 qcow2 lazy refcounts test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Khoa Huynh , Anthony Liguori , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC57A12B44E4DBFF8F4FFD5AA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/25/2012 06:21 AM, Stefan Hajnoczi wrote: > This tests establishes the basic post-conditions of the qcow2 lazy > refcounts features: >=20 > 1. If the image was closed normally, it is marked clean. >=20 > 2. If an allocating write was performed and the image was not close > normally, then it is marked dirty. >=20 > a. Written data can be read back successfully. > b. The image file can be repaired and will be marked clean again. >=20 > Signed-off-by: Stefan Hajnoczi > +++ b/tests/qemu-iotests/039 > @@ -0,0 +1,117 @@ > +#!/bin/bash Since you are assuming bash (and even if you were to assume POSIX /bin/sh)... > + > +seq=3D`basename $0` I prefer $() over ``. > +echo "QA output created by $seq" > + > +here=3D`pwd` POSIX (and therefore bash) guarantees that $PWD is sane, and faster to access than $(pwd). > +tmp=3D/tmp/$$ That's not very secure. It may be worth using bash's $RANDOM, or using mkstemp(1). Beyond that, the series seemed reasonable to me. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigC57A12B44E4DBFF8F4FFD5AA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQEDLrAAoJEKeha0olJ0NqjrkIAKrcNLTg2uxv8Avgxp3GFJiy oHK3Efv2fXzYmOSE0xexKLLHpo9k9vRLfL4krFFTHNrm7ExSlBRft3EvtIAqPu/b BRJ0m0NwO6bA56rA3bJ6rwIAtLj3UrvHHKreBuGYVYYbBFVe86GFgpZYwTqAOcGw ESoAmGQb1aWlGBrybF6FcII9dkL77AuKJ7LZdmwQb1Bvuvt75P5mVdUj+sSfRw8Z +drZR3Zu9YuknGFcM4kwwImXv/Bzsb1CgL6X0GJ5ib8U17cVtSqKY0Z1OQfHXCwA VRQGCkT0RzgyeDI4wQvveN71xMc9AoKSNyeSrELPjiDclgYWL/krJt6Qu8AkAP8= =9WSL -----END PGP SIGNATURE----- --------------enigC57A12B44E4DBFF8F4FFD5AA--