From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su68v-0003Rh-PM for qemu-devel@nongnu.org; Wed, 25 Jul 2012 14:17:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su68u-0001aA-Jo for qemu-devel@nongnu.org; Wed, 25 Jul 2012 14:17:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su68u-0001Zs-BU for qemu-devel@nongnu.org; Wed, 25 Jul 2012 14:17:04 -0400 Message-ID: <50103815.3090503@redhat.com> Date: Wed, 25 Jul 2012 12:16:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343048885-1701-1-git-send-email-coreyb@linux.vnet.ibm.com> <1343048885-1701-3-git-send-email-coreyb@linux.vnet.ibm.com> In-Reply-To: <1343048885-1701-3-git-send-email-coreyb@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig69235CCFEB80364897E05B78" Subject: Re: [Qemu-devel] [PATCH v5 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, libvir-list@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig69235CCFEB80364897E05B78 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/23/2012 07:08 AM, Corey Bryant wrote: > This patch adds support that enables passing of file descriptors > to the QEMU monitor where they will be stored in specified file > descriptor sets. >=20 > +## > +# @add-fd: > +# > +# Add a file descriptor, that was passed via SCM rights, to an fd set.= > +# > +# @fdset_id: The ID of the fd set to add the file descriptor to. Should this parameter be optional, in which case qemu generates the set number as the next available? The return information would include the set number whether or not this parameter was present from the caller, and allowing it to be optional makes it slightly easier for callers to generate a new set without having to make the caller track which set ids are in use. > +## > +# @remove-fd: > +# > +# Remove a file descriptor from an fd set. > +# > +# @fdset_id: The ID of the fd set that the file descriptor belongs to.= > +# > +# @fd: The file descriptor that is to be removed. Should 'fd' be optional, as a shorthand for saying that _all_ fds belonging to the set be marked as removed at once? > +++ b/qmp-commands.hx > @@ -926,6 +926,127 @@ Example: > =20 > EQMP > =20 > + { > + .name =3D "add-fd", > + .args_type =3D "fdset_id:i", > + .params =3D "add-fd fdset_id", > + .help =3D "Add a file descriptor, that was passed via SC= M rights, to an fd set", > + .mhandler.cmd_new =3D qmp_marshal_input_add_fd, > + }, > + > +SQMP > +add-fd > +------- > + > +Add a file descriptor, that was passed via SCM rights, to an fd set. > + > +Arguments: > + > +- "fdset_id": The ID of the fd set to add the file descriptor to. (js= on-int) May need tweaking, based on the answers to the above questions. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig69235CCFEB80364897E05B78 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQEDgVAAoJEKeha0olJ0NqUCAIAIPgJsgEq1EIfpD9JPxO/Opd LK6LPwCB46/7rtavG1nJ7jhAIgkE70SqtCCaUhRLe8RWj+xaWEIpUtOp1WCGdQuK TqrYzmdK1jXx+0QfQGS3rXyO504Y58XGJj7gzngMvuP7kfcSQMhq12WCLLm601OF JdCxls6Zt7ttI5la/BxmE3xdb+BIAPGwIIh8QSW8/fKsftWSVr/9eyWjJUzq9Ojt 5F6e+hpmLCseJRvazYAk5ovC3WVLOapqO3NU8FuQQj6jp2XFO8eHFVmgY7V1qyV5 2x9xUcRMnbWDTfPkK1y4yG/V38exTWulKQj0qqJXcfUpHkNIugqZJU93jkhTeik= =knv3 -----END PGP SIGNATURE----- --------------enig69235CCFEB80364897E05B78--