From: Eric Blake <eblake@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: libvir-list@redhat.com, Jiri Denemark <jdenemar@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [libvirt] [QEMU PATCH 1/3] vl.c: extract qemu_machine_init() function
Date: Wed, 25 Jul 2012 16:18:01 -0600 [thread overview]
Message-ID: <50107099.9050902@redhat.com> (raw)
In-Reply-To: <1343240323-7402-2-git-send-email-ehabkost@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 692 bytes --]
On 07/25/2012 12:18 PM, Eduardo Habkost wrote:
> Other code directly related to the board init function may be moved
> there.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> hw/boards.h | 7 +++++++
> vl.c | 14 +++++++++++++-
> 2 files changed, 20 insertions(+), 1 deletion(-)
>
>
> - machine->init(ram_size, boot_devices,
> + qemu_machine_init(machine, ram_size, boot_devices,
> kernel_filename, kernel_cmdline, initrd_filename, cpu_model);
Doesn't this next line also need an indentation adjustment?
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-07-25 22:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 18:18 [Qemu-devel] [QEMU PATCH 0/3] versioned CPU models / per-machine-type aliases Eduardo Habkost
2012-07-25 18:18 ` [Qemu-devel] [QEMU PATCH 1/3] vl.c: extract qemu_machine_init() function Eduardo Habkost
2012-07-25 22:18 ` Eric Blake [this message]
2012-07-30 16:19 ` [Qemu-devel] [libvirt] " Eduardo Habkost
2012-07-25 18:18 ` [Qemu-devel] [QEMU PATCH 2/3] per-machine-type CPU model alias system Eduardo Habkost
2012-07-25 22:46 ` Andreas Färber
2012-07-25 18:18 ` [Qemu-devel] [QEMU PATCH 3/3] x86: pc: versioned CPU model names & compatibility aliases Eduardo Habkost
2012-07-25 22:52 ` Andreas Färber
2012-07-26 14:24 ` Eduardo Habkost
2012-07-26 14:31 ` Andreas Färber
2012-07-26 14:48 ` Eduardo Habkost
2012-07-31 13:22 ` Igor Mammedov
2012-07-31 13:44 ` Eduardo Habkost
2012-07-26 14:33 ` Jiri Denemark
2012-07-26 14:54 ` Eduardo Habkost
2012-07-25 23:43 ` [Qemu-devel] [QEMU PATCH 0/3] versioned CPU models / per-machine-type aliases Anthony Liguori
2012-07-26 13:53 ` Eduardo Habkost
2012-07-26 14:06 ` Andreas Färber
2012-07-26 14:29 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50107099.9050902@redhat.com \
--to=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jdenemar@redhat.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).