From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su9uC-0003VH-WB for qemu-devel@nongnu.org; Wed, 25 Jul 2012 18:18:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su9uB-0002mH-Vt for qemu-devel@nongnu.org; Wed, 25 Jul 2012 18:18:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su9uB-0002m1-Mq for qemu-devel@nongnu.org; Wed, 25 Jul 2012 18:18:07 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6PMI7fQ008947 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 25 Jul 2012 18:18:07 -0400 Message-ID: <50107099.9050902@redhat.com> Date: Wed, 25 Jul 2012 16:18:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343240323-7402-1-git-send-email-ehabkost@redhat.com> <1343240323-7402-2-git-send-email-ehabkost@redhat.com> In-Reply-To: <1343240323-7402-2-git-send-email-ehabkost@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigCACF220CC8D92059B797743A" Subject: Re: [Qemu-devel] [libvirt] [QEMU PATCH 1/3] vl.c: extract qemu_machine_init() function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: libvir-list@redhat.com, Jiri Denemark , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigCACF220CC8D92059B797743A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 07/25/2012 12:18 PM, Eduardo Habkost wrote: > Other code directly related to the board init function may be moved > there. >=20 > Signed-off-by: Eduardo Habkost > --- > hw/boards.h | 7 +++++++ > vl.c | 14 +++++++++++++- > 2 files changed, 20 insertions(+), 1 deletion(-) >=20 > =20 > - machine->init(ram_size, boot_devices, > + qemu_machine_init(machine, ram_size, boot_devices, > kernel_filename, kernel_cmdline, initrd_filename, cp= u_model); Doesn't this next line also need an indentation adjustment? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigCACF220CC8D92059B797743A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQEHCZAAoJEKeha0olJ0NqhfwIAKB3/lw0myv3Ch4ahj25En0r kRVxh9ajyOu+N4GOXVY/Gc5odsmf+5O3Eq4AL+o08uo3MJ4pDSfNc8K5gf21/rIF YH6PVRni0GKwrF4ssJ6TtPwQr6S6tINf616JcXRYCnvOOa/SPg8+ksN3UppURKTR MhmIqPfg3HUIj2cDIZJYe3Y/7mATelgrQAQ3KhduXGgfOtv3TME5fBMcl2PvpB2S LoGk+cGktYXVG1jpw5NQcglEP+YrGWLIcDQBdMIYjeN7y5uFv5Qdu2mX1RCMadlu DCmPho4f1VcZk+kAbwPwqHZktXADcdmrhmTxqXt0UZ+cU08peZXgwkjji9JH0+c= =/iS+ -----END PGP SIGNATURE----- --------------enigCACF220CC8D92059B797743A--