From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuNDr-0004jD-Fp for qemu-devel@nongnu.org; Thu, 26 Jul 2012 08:31:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SuNDl-0008U1-H8 for qemu-devel@nongnu.org; Thu, 26 Jul 2012 08:31:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuNDl-0008TR-5G for qemu-devel@nongnu.org; Thu, 26 Jul 2012 08:31:13 -0400 Message-ID: <5011385F.7000509@redhat.com> Date: Thu, 26 Jul 2012 06:30:23 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343301366-18028-1-git-send-email-benoit@irqsave.net> <1343301366-18028-3-git-send-email-benoit@irqsave.net> In-Reply-To: <1343301366-18028-3-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig6CA36A787F15D13E0771A14B" Subject: Re: [Qemu-devel] [PATCH V4 2/3] block: Use bdrv_get_backing_file_depth() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: benoit.canet@gmail.com Cc: kwolf@redhat.com, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6CA36A787F15D13E0771A14B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/26/2012 05:16 AM, benoit.canet@gmail.com wrote: > From: Beno=C3=AEt Canet >=20 > Use the dedicated counting function in qmp_query_block in order to > propagate the backing file depth to HMP. >=20 > # > +# @backing-file-depth: the count of ancestor's backing files (since: 1= =2E2) > +# That still reads awkwardly; I had suggested completely ditching the word 'ancestor': @backing_file_depth: number of files in the backing file chain (since: 1.= 2) Also missing a counterpart patch to query-block in qmp-commands.hx to list the new backing-file-depth field. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig6CA36A787F15D13E0771A14B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQEThfAAoJEKeha0olJ0NqW4QIAKDQNjiK0uC3L0Pgslq86Ah8 WMXcvj6pLZt5MKlaEWEXHfUO0ObWylsraC/Cut9mKR8wfgVZ038sSYrwQxsLnXJB HpWAxUII4pF7JJo1rLnz5EDyaYovG+75W3ueGM37gE/IRRnNprbhLWrzVIHTfgkq kmm/PI4IyAey93n6emr8go+VTVXNryQcWJ0m4Ts1aqDpBrE++ILG65pcy3btlj74 vqrh8u8dRlkeiexbnwzFACepP3/VoJA9B4JdyL2jIQfIuaD5tP5yCLbjmHJF7Ftq EMUVvML7vVHfnItrD/53TEstF8/EQ3oLrvUV1geihX/06mf/4odPGqmDgaVuEBI= =1/Zj -----END PGP SIGNATURE----- --------------enig6CA36A787F15D13E0771A14B--