From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuNf6-0006j1-Ch for qemu-devel@nongnu.org; Thu, 26 Jul 2012 08:59:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SuNf0-0008Tb-KY for qemu-devel@nongnu.org; Thu, 26 Jul 2012 08:59:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuNf0-0008TR-CY for qemu-devel@nongnu.org; Thu, 26 Jul 2012 08:59:22 -0400 Message-ID: <50113F26.4010604@redhat.com> Date: Thu, 26 Jul 2012 06:59:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <1343249431-9245-1-git-send-email-lcapitulino@redhat.com> <1343249431-9245-4-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1343249431-9245-4-git-send-email-lcapitulino@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigDB902BD0C09AFF62966BDCBD" Subject: Re: [Qemu-devel] [PATCH 03/14] qerror: drop qerror_abort() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDB902BD0C09AFF62966BDCBD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/25/2012 02:50 PM, Luiz Capitulino wrote: > Previously, developers had to create error dicts manually and also ente= r > the matching desc table entry. Thus, qerro_abort() was added to help s/qerro_/qerror_/ > catching bad error dicts. >=20 > Today, all that stuff is generated automatically which makes the chance= > of a bad generated dict quite low. >=20 > Also, qerror_abort() would... _abort_ on a bad error dict! >=20 > This commit maintains the same verification logic on the error object > but drops the abort() in favor of reporting UndefinedError for bad dict= s > (and also print a debug message to stderr). >=20 > Signed-off-by: Luiz Capitulino > --- --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigDB902BD0C09AFF62966BDCBD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQET8mAAoJEKeha0olJ0NqP1cH/359frzFg3+jY6gcDkzC7Qez kWHSibq6L5pEXeM+gOJQn/JQqKocgHxF7NmDeF4HJ5BS+efzvUzjwxvvKmVrtm94 6PbcdRCISui6OIPGNRifeloP3EEdZhO3WeQB0MxG3mG4FIz2leMlcP+ozbZ0yQEa aQQpJomwz6A4IdoaV/9aDjTYMOezwDklXk4O8l8cDzpi1DFWasuobAzi6fwU1ITW wTVj4/cs+m0m5DWXZib0qzZ5toE/Nr1JXm1zN+HRiydpQ7L/gXBWvZv8o0nl8Qb/ x0vcOR/y8aJV9VtN9pDYXWXLzaCjrCBj/qJp6vE0X8GQN35auBXHJEuPdLW7xeA= =XgYa -----END PGP SIGNATURE----- --------------enigDB902BD0C09AFF62966BDCBD--