From: Avi Kivity <avi@redhat.com>
To: liu ping fan <qemulist@gmail.com>
Cc: kvm@vger.kernel.org, Stefan Hajnoczi <stefanha@gmail.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
Jan Kiszka <jan.kiszka@siemens.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it
Date: Thu, 26 Jul 2012 16:00:52 +0300 [thread overview]
Message-ID: <50113F84.6010802@redhat.com> (raw)
In-Reply-To: <CAJnKYQ=mfeC37A7Awy4aRha40ED9JzLL4E2OYXBTBAP_S9YqbQ@mail.gmail.com>
On 07/26/2012 03:56 PM, liu ping fan wrote:
> On Wed, Jul 25, 2012 at 5:08 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 25/07/2012 05:31, Liu Ping Fan ha scritto:
>>> From: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
>>>
>>> rwlock:
>>> qemu_device_tree_mutex
>>>
>>> rd side:
>>> --device_del(destruction of device will be postphoned until unplug
>>> ack from guest),
>>> --pci hot-unplug
>>> --iteration (qdev_reset_all)
>>>
>>> wr side:
>>> --device_add
>>>
>>
>> This is not defined anywhere, is a piece missing in the patch?
>>
> Oh, yes, I miss the patch. In that patch, these rwlock are just place holder.
> I see there is already try to implement rwlock for qemu.
> http://lists.gnu.org/archive/html/qemu-devel/2011-10/msg00192.html
> and is it the time for introduce rwlock for qemu?
>From the description above, I don't see why it can't be a mutex.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-07-26 13:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 3:31 [Qemu-devel] [PATCH 0/5] prepare unplug out of protection of global lock Liu Ping Fan
2012-07-25 3:31 ` [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it Liu Ping Fan
2012-07-25 9:08 ` Paolo Bonzini
2012-07-26 12:56 ` liu ping fan
2012-07-26 13:00 ` Avi Kivity [this message]
2012-07-26 13:14 ` liu ping fan
2012-07-26 13:15 ` Avi Kivity
2012-07-26 13:21 ` liu ping fan
2012-07-26 13:46 ` Avi Kivity
2012-07-25 3:31 ` [Qemu-devel] [PATCH 2/5] exec.c: use refcnt to protect device during dispatching Liu Ping Fan
2012-07-25 7:43 ` Stefan Hajnoczi
2012-07-25 8:12 ` liu ping fan
2012-07-25 9:18 ` Paolo Bonzini
2012-07-26 13:00 ` liu ping fan
2012-07-25 10:58 ` Avi Kivity
2012-07-25 12:27 ` Avi Kivity
2012-07-26 13:06 ` liu ping fan
2012-07-26 13:13 ` Avi Kivity
2012-07-25 3:31 ` [Qemu-devel] [PATCH 3/5] hotplug: introduce qdev_unplug_ack() to remove device from views Liu Ping Fan
2012-07-25 10:58 ` Avi Kivity
2012-07-25 3:31 ` [Qemu-devel] [PATCH 4/5] qom: delay DeviceState's reclaim to main-loop Liu Ping Fan
2012-07-25 7:03 ` Stefan Hajnoczi
2012-07-25 7:37 ` Paolo Bonzini
2012-07-25 8:16 ` liu ping fan
2012-07-25 8:22 ` Paolo Bonzini
2012-07-25 8:17 ` liu ping fan
2012-07-25 3:31 ` [Qemu-devel] [PATCH 5/5] e1000: using new interface--unmap to unplug Liu Ping Fan
2012-07-25 7:12 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50113F84.6010802@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).