From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42803)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SuO8I-0005ZJ-Cs
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 09:29:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SuO8C-0000my-KQ
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 09:29:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36945)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SuO8C-0000mm-CP
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 09:29:32 -0400
Message-ID: <501145F7.6010705@redhat.com>
Date: Thu, 26 Jul 2012 15:28:23 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1343218884-14980-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1343218884-14980-8-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <1343218884-14980-8-git-send-email-stefanha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 7/7] qemu-iotests: add 039 qcow2 lazy
	refcounts test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Khoa Huynh <khoa@us.ibm.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

Am 25.07.2012 14:21, schrieb Stefan Hajnoczi:
> This tests establishes the basic post-conditions of the qcow2 lazy
> refcounts features:
> 
>   1. If the image was closed normally, it is marked clean.
> 
>   2. If an allocating write was performed and the image was not close
>      normally, then it is marked dirty.
> 
>      a. Written data can be read back successfully.
>      b. The image file can be repaired and will be marked clean again.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

I think an important case that is missing here is opening a dirty image
rw without having run qemu-img check -r first.

> +== Read-only access must still work ==
> +read 512/512 bytes at offset 0
> +512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +incompatible_features     0x1
> +
> +== Repairing the image file must succeed ==
> +ERROR OFLAG_COPIED: offset=8000000000050000 refcount=0
> +Repairing cluster 5 refcount=0 reference=1
> +No errors were found on the image.
> +incompatible_features     0x0

I wonder what happened to the "The following inconsistencies were found
and repaired" message. Most likely not a problem with qemu-iotests,
though, but something unexpected in qemu-img.

Kevin