From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuOQz-00016I-7i for qemu-devel@nongnu.org; Thu, 26 Jul 2012 09:49:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SuOQr-0006Yf-I4 for qemu-devel@nongnu.org; Thu, 26 Jul 2012 09:48:57 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44942 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuOQr-0006YZ-BQ for qemu-devel@nongnu.org; Thu, 26 Jul 2012 09:48:49 -0400 Message-ID: <50114ABC.2030609@suse.de> Date: Thu, 26 Jul 2012 15:48:44 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1343115430-34285-1-git-send-email-borntraeger@de.ibm.com> <1343115430-34285-8-git-send-email-borntraeger@de.ibm.com> <500F9855.7020005@de.ibm.com> In-Reply-To: <500F9855.7020005@de.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 7/7] s390: make sclp ascii console the default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Blue Swirl , Heinz Graalfs , qemu-devel , Alexander Graf , Jens Freimann Am 25.07.2012 08:55, schrieb Christian Borntraeger: > On 24/07/12 21:35, Blue Swirl wrote: > [...] >> Braces > [...] >> Braces, also below two times. >=20 > a generic question. We did it that way because the other code in vl.c i= s like that. >=20 > So we should make new code follow the CodingStyle even if the surroundi= ng code looks > different, but we dont touch that surrounding code. right? There has been resistance towards doing touch-all Coding Style cleanups since it is invasive and messes with git-blame. Our policy is to have new code comply with the current Coding Style (with some exceptions in audio code) and to apply fixes (e.g., add braces) on the lines touched or in the same hunk. scripts/checkpatch.pl complains otherwise. Depending on amount and invasiveness of such cleanups it has sometimes been requested (e.g., for code movements that show up as deletes and adds) that larger cleanups be split out into a preceding patch, to keep things reviewable and to avoid checkpatch.pl errors. HTE, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg